Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] tutorials: explicit translation function example #11332

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

samueljlieber
Copy link
Contributor

@samueljlieber samueljlieber commented Nov 5, 2024

This PR fixes the explicit export translation function example and definition links in the Chapter 2: Build a dashboard developer tutorial's 12. Going further section seealso- currently they lead to a 404 and are outdated.

Please let me know if there is a more relevant / accurate example to link than what I have in this PR :)

Changes:

  1. addons/account/static/src/components/bills_upload/bills_upload.js#L64 ➡️ addons/account/static/src/components/bills_upload/bills_upload.js#L116
  2. addons/web/static/src/core/l10n/translation.js#L16 ➡️ addons/web/static/src/core/l10n/translation.js#L22

@samueljlieber samueljlieber self-assigned this Nov 5, 2024
@robodoo
Copy link
Collaborator

robodoo commented Nov 5, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team November 5, 2024 16:14
@samueljlieber samueljlieber force-pushed the 17.0-developer-explicit-export-translation-example-sali branch from 221422c to 534c397 Compare November 5, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants