[IMP] runbot: dockerfile variants #1118
Open
+148
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file does not contain any templates anymore.
Williambraecky
changed the title
Williambraecky
force-pushed
the
18.0-docker-variants-wbr
branch
2 times, most recently
from
84f0f00 to
be9d43e
Compare
Xavier-Do
reviewed
Mar 31, 2025
runbot/models/docker.py
Outdated
| def _compute_image_tag(self): | ||
| for rec in self: | ||
| if rec.name: | ||
| if rec.parent_id and rec.variant_name: | ||
| variant_sub_tag = re.sub(r'[ /:\(\)\[\]]', '', rec.variant_name.lower()) |
There was a problem hiding this comment.
Would be simpler to have a constraints on name instead of cleaning it (historical mistake)
Williambraecky
force-pushed
the
18.0-docker-variants-wbr
branch
from
be9d43e to
f80588b
Compare
Xavier-Do
reviewed
Apr 1, 2025
| UPDATE runbot_dockerfile | ||
| SET name=REGEXP_REPLACE( | ||
| REPLACE(name, '.', '_'), | ||
| '[ /:\(\)\[\]]', '', 'g' |
There was a problem hiding this comment.
Maybe we could just use the tag ? (still replacing dots by _)
There was a problem hiding this comment.
Tbh the query is not complete as we disallow a lot more characters than before, this query takes care of our data mostly.
(only concerns 13.0 and DockerSaas17.2)
I don't think it's worth doing much more.
Williambraecky
force-pushed
the
18.0-docker-variants-wbr
branch
from
f80588b to
3c35165
Compare
Dockerfile variants are dockerfile that depend on another dockerfile while adding layers, which should not be present in the regular image. Strictly speaking it is the same as creating a new dockerfile with a reference docker layer at the top, except that layer is implicit and will not clutter the docker image. Variants must be unique.
The field was there for historical and migration reasons but is not used any longer and docker layer answer to all the needs we have.
Williambraecky
force-pushed
the
18.0-docker-variants-wbr
branch
from
3c35165 to
074839c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.