One Odra Core to rule them all #266
Merged
+386
−524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpob
requested changes
Nov 23, 2023
There was a problem hiding this comment.
#264 introduced some changes that centralize usage of odra::* paths. If you sync with the current release/0.8.0 it reduces changes in odra-macros crate. You me face a lot of conflicts but you should take those from release and apply changes in odra_macros::utils::* modules.
and odra-types into odra-core
kubaplas
force-pushed
the
feature/merge-utils-shared-types-into-core
branch
from
987f4e3 to
88cbdf9
Compare
kpob
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged odra-utils, odra-casper-shared and odra-types into odra-core