-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use snake case when locating wasm files - makes cargo odra so much #311
Conversation
WalkthroughThe recent update incorporates the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (3)
- Cargo.toml
- odra-casper/test-vm/Cargo.toml
- odra-macros/Cargo.toml
Files selected for processing (1)
- odra-casper/test-vm/src/vm/casper_vm.rs (2 hunks)
Additional comments: 2
odra-casper/test-vm/src/vm/casper_vm.rs (2)
1-1: The addition of the
convert_case
crate is noted and is in line with the PR's objective to standardize the naming convention of wasm files to snake_case.271-275: The conversion to snake_case using the
convert_case
crate appears to be implemented correctly. However, it's important to ensure that all wasm file names and references throughout the codebase are updated to reflect this new naming convention to avoid file not found errors.Verification successful
The verification process has confirmed that the
.wasm
files and their references in the codebase adhere to the snake_case naming convention as intended by the PR. The changes made in the PR are consistent with the goal of simplifying the cargo odra process by standardizing the naming convention of wasm files.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that all wasm file names follow the new snake_case naming convention. fd '.wasm$' --exec bash -c 'if [[ ! "$(basename {})" =~ ^[a-z0-9_]+\.wasm$ ]]; then echo "Non-snake_case wasm file found: {}"; fi' # Verify that all references to wasm files in the codebase use the new snake_case naming convention. rg --type rust --glob '*.rs' '[a-zA-Z][a-zA-Z0-9]*\.wasm'Length of output: 407
Script:
#!/bin/bash # Search for any references to .wasm files in the codebase to ensure they follow the snake_case naming convention. rg --type rust --glob '*.rs' '\b[a-zA-Z0-9_/]+\.wasm\b'Length of output: 187
Not needed, as we are dropping name from contract section of Odra.toml |
easier
Summary by CodeRabbit