Remove try-from-macro crate #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove local crate * add derive_try_from_ref crate from crates.io
WalkthroughThe codebase underwent a refactoring where the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (3)
Cargo.tomlis excluded by:!**/*.tomlodra-macros/Cargo.tomlis excluded by:!**/*.tomltry-from-macro/Cargo.tomlis excluded by:!**/*.toml
Files selected for processing (10)
- odra-macros/src/ast/blueprint.rs (2 hunks)
- odra-macros/src/ast/deployer_item.rs (3 hunks)
- odra-macros/src/ast/exec_parts.rs (2 hunks)
- odra-macros/src/ast/external_contract_item.rs (2 hunks)
- odra-macros/src/ast/host_ref_item.rs (2 hunks)
- odra-macros/src/ast/module_impl_item.rs (1 hunks)
- odra-macros/src/ast/module_struct_item.rs (1 hunks)
- odra-macros/src/ast/odra_type_item.rs (2 hunks)
- odra-macros/src/ast/ref_item.rs (2 hunks)
- odra-macros/src/ast/test_parts.rs (2 hunks)
Additional comments: 27
odra-macros/src/ast/module_struct_item.rs (2)
- 6-6: The change from
derive_try_fromtoderive_try_from_refaligns with the PR objectives to replace the local crate with a standardized community-supported crate.- 10-10: The addition of
#[err(syn::Error)]toModuleStructItemis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.odra-macros/src/ast/module_impl_item.rs (3)
- 8-8: The change from
derive_try_fromtoderive_try_from_refaligns with the PR objectives to replace the local crate with a standardized community-supported crate.- 12-12: The addition of
#[err(syn::Error)]toModuleImplItemis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.- 14-14: The change from
#[expr(item.self_code())]to#[expr(input.self_code())]likely aligns with the requirements or conventions of the newly adoptedderive_try_from_refcrate.odra-macros/src/ast/blueprint.rs (4)
- 1-1: The change from
derive_try_fromtoderive_try_from_refaligns with the PR objectives to replace the local crate with a standardized community-supported crate.- 10-10: The addition of
#[err(syn::Error)]toBlueprintItemis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.- 12-12: The change from
#[expr(utils::attr::odra_module(&item.module_str()?))]to#[expr(utils::attr::odra_module(&input.module_str()?))]likely aligns with the requirements or conventions of the newly adoptedderive_try_from_refcrate.- 19-19: The addition of
#[err(syn::Error)]toBlueprintModItemis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.odra-macros/src/ast/external_contract_item.rs (4)
- 6-6: The change from
derive_try_fromtoderive_try_from_refaligns with the PR objectives to replace the local crate with a standardized community-supported crate.- 10-10: The addition of
#[err(syn::Error)]toExternalContractImplis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.- 12-12: The change from
#[expr(item.self_code())]to#[expr(input.self_code())]likely aligns with the requirements or conventions of the newly adoptedderive_try_from_refcrate.- 21-21: The addition of
#[err(syn::Error)]toTestPartsItemis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.odra-macros/src/ast/deployer_item.rs (3)
- 1-1: The change from
derive_try_fromtoderive_try_from_refaligns with the PR objectives to replace the local crate with a standardized community-supported crate.- 55-55: The addition of
#[err(syn::Error)]toContractInitFnis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.- 73-73: The addition of
#[err(syn::Error)]toDeployerItemis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.odra-macros/src/ast/ref_item.rs (2)
- 4-4: The change from
derive_try_fromtoderive_try_from_refaligns with the PR objectives to replace the local crate with a standardized community-supported crate.- 120-120: The addition of
#[err(syn::Error)]toRefItemis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.odra-macros/src/ast/exec_parts.rs (3)
- 6-6: The change from
derive_try_fromtoderive_try_from_refaligns with the PR objectives to replace the local crate with a standardized community-supported crate.- 168-168: The addition of
#[err(syn::Error)]toExecPartsModuleItemis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.- 172-172: The change from
#[expr(item.exec_parts_mod_ident())]to#[expr(input.exec_parts_mod_ident())]likely aligns with the requirements or conventions of the newly adoptedderive_try_from_refcrate.odra-macros/src/ast/odra_type_item.rs (2)
- 8-8: The change from
derive_try_fromtoderive_try_from_refaligns with the PR objectives to replace the local crate with a standardized community-supported crate.- 32-32: The addition of
#[err(syn::Error)]toOdraTypeItemis consistent with the PR's aim to enhance error handling by integrating with thesyncrate's error reporting.odra-macros/src/ast/test_parts.rs (2)
- 1-1: The import statement has been correctly updated to use
derive_try_from_ref::TryFromRefinstead ofderive_try_from::TryFromRef.- 51-51: The addition of the
#[err(syn::Error)]attribute to theTestPartsItemstruct is consistent with the PR objectives to enhance error handling.odra-macros/src/ast/host_ref_item.rs (2)
- 2-2: The import statement in
host_ref_item.rshas been updated to usederive_try_from_ref::TryFromRef, aligning with the changes intest_parts.rs.- 218-218: The
#[err(syn::Error)]attribute has been added to theHostRefItemstruct, which is in line with the PR's goal to improve error handling.
zie1ony
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit