Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace print in precalc by logging #125

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Replace print in precalc by logging #125

merged 5 commits into from
Oct 23, 2023

Conversation

joroeder
Copy link
Member

There are print statements in the hydraulic pre calculation. This PR replaces them by logging.info.

jnettels
jnettels approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@jnettels jnettels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the usage of the logging function, but in my opinion it could be improved even further, by creating a logger first and then calling logger.info().
See my note about that in #129.

Cheers

dhnx/optimization/precalc_hydraulic.py Outdated Show resolved Hide resolved
dhnx/optimization/precalc_hydraulic.py Outdated Show resolved Hide resolved
dhnx/optimization/precalc_hydraulic.py Outdated Show resolved Hide resolved
dhnx/optimization/precalc_hydraulic.py Outdated Show resolved Hide resolved
@jnettels jnettels merged commit a66d25c into dev Oct 23, 2023
8 of 9 checks passed
@jnettels jnettels deleted the Fix/Replace_print_in_precalc branch October 23, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnettels jnettels jnettels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joroeder @jnettels