Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kwargs explicit #40

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Make kwargs explicit #40

merged 5 commits into from
Dec 19, 2023

Conversation

p-snft
Copy link
Member

@p-snft p-snft commented Dec 14, 2023

At the moment, unknown arguments are silently ignored. Moving to explicit arguments fixes that.

@p-snft p-snft self-assigned this Dec 14, 2023
@p-snft p-snft added the enhancement New feature or request label Dec 14, 2023
@p-snft p-snft added this to the v1.0.0 milestone Dec 14, 2023
@p-snft p-snft linked an issue Dec 14, 2023 that may be closed by this pull request
@p-snft p-snft requested a review from a team December 14, 2023 19:57
Copy link

@henhuy henhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did you ran oemof.solph tests on network from this branch?

@p-snft
Copy link
Member Author

p-snft commented Dec 15, 2023

Solph hands some ignored arguments to network, that do cause errors when we move to explicitly named arguments. I have the an accompanying PR for solph: oemof/oemof-solph#1032

@p-snft p-snft merged commit c364657 into dev Dec 19, 2023
12 checks passed
@p-snft p-snft deleted the revision/explicit_kwargs branch December 19, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to explicit arguments
2 participants