Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "nominal_value" of Flow #991

Open
p-snft opened this issue Oct 12, 2023 · 2 comments · May be fixed by #1114
Open

Rename "nominal_value" of Flow #991

p-snft opened this issue Oct 12, 2023 · 2 comments · May be fixed by #1114
Assignees
Milestone

Comments

@p-snft
Copy link
Member

p-snft commented Oct 12, 2023

For Flow, we have the keyword nominal_value. I think, the capacity of a Flow (e.g. a power line) is actually easier to interpret as the "nominal value". Actually, I have been asked that quite some times. If we have a nominal_capacity of a Flow, it would be arguable why it's nominal_storage_capacity for the GenericStorage. So we need to say either nominal_flow_capacity which is actually redundant. In my opinion, it makes sense to call both nominal_capacity.

In fact, they are quite similar. In particular, they both accept a number (fixed capacity) or an Investment object.

@upadhayaajay
Copy link

I occasionally find it confusing; using the name nominal_value seems less intuitive. It might make more sense to name it nominal_capacity as you suggested, providing a clearer indication of its meaning. I agree with your suggestion to rename both to nominal_capacity.

_

@p-snft p-snft self-assigned this Aug 2, 2024
@p-snft
Copy link
Member Author

p-snft commented Aug 2, 2024

I still have to keep explaining people what the nominal_value is meant for and they just understand if I name it nominal_capacity, instead. I think, we should really do this.

@p-snft p-snft added this to the minor release milestone Aug 22, 2024
@p-snft p-snft linked a pull request Aug 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants