Revision/rename nominal value #1114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still have to keep explaining people what the nominal_value is meant for and they just understand if I name it nominal_capacity, instead. Reflecting a bit, the capacity of a Flow (e.g. a power line) is easier to interpret as the "nominal value". Thus the refactoring.
This way, it is analogue to teh keyword of the Flow.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, the capacity of a
Flow(e.g. a power line) is actually easier to interpret as the "nominal value". Actually, I have been asked that quite some times. If we have anominal_capacityof aFlow, it would be arguable why it'snominal_storage_capacityfor theGenericStorage. So we need to say eithernominal_flow_capacitywhich is actually redundant. In my opinion, it makes sense to call bothnominal_capacity.In fact, they are quite similar. In particular, they both accept a number (fixed capacity) or an Investment object.