Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce variable for storage losses #1090

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Introduce variable for storage losses #1090

merged 8 commits into from
Jul 10, 2024

Commits on Jul 9, 2024

  1. Explicitly infer last interval in storage example

    @p-snft
    p-snft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ced3300 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into feature/storage_losses

    @p-snft
    p-snft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    98fef1e View commit details
    Browse the repository at this point in the history

  3. Reapply "Introduce variable for storage losses" 

    This reverts commit 6dae8bc.
    @p-snft
    p-snft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    170173a View commit details
    Browse the repository at this point in the history

  4. Adapt tests to storage loss variable 

    This commit includes changed line orders in the LP files,
as the order is just random and I was too lazy to change
everything by hand.
    @p-snft
    p-snft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d254041 View commit details
    Browse the repository at this point in the history

  5. Adhere to Black 

    I didn't actually touch this but having a separate PR
doesn't make too much sense, IMHO.
    @p-snft
    p-snft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    fe77cdd View commit details
    Browse the repository at this point in the history

  6. Document new variable

    @p-snft
    p-snft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a44eda1 View commit details
    Browse the repository at this point in the history

  7. Fix loss calculation for non-hourly time steps 

    This one first slipped through due to too many irrelevant changes
in the LP files. I now added a unit test that is independent of lp files.

Note that the formula is more complicated but it just changes a value
in the lp file, so it will not significantly increase computational time.
    @p-snft
    p-snft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f849db9 View commit details
    Browse the repository at this point in the history

  8. Fix import order

    @p-snft
    p-snft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    053b349 View commit details
    Browse the repository at this point in the history