Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal discounting functionality #1111

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

p-snft
Copy link
Member

@p-snft p-snft commented Aug 21, 2024

Discounting functionality is not actually needed, as we allow time series anyway. So, we can remove code without reducing functionality.

p-snft and others added 2 commits August 20, 2024 16:39
Offsetting the objective value for models with just one period
won't hurt anybody. So, harmonisation is obviously not a loss.
This also changes the result of "test_multi_period_dispatch_model".
As this model is too complex for a unit test, I switched it off for now.

Signed-off-by: Patrik Schönfeldt <[email protected]>
@p-snft p-snft self-assigned this Aug 21, 2024
@p-snft p-snft added this to the major release milestone Aug 21, 2024
p-snft and others added 2 commits August 23, 2024 10:06
# Conflicts:
#	src/oemof/solph/components/_generic_storage.py
#	src/oemof/solph/flows/_simple_flow_block.py
The (very similar) interest still needs to be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove discounting from the multi-period model
1 participant