Adapt to cleaned up oemof.network #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
p-snft
commented
Oct 11, 2023
p-snft
commented
- Fix "Flow" does not have "_in_edges"
In old versions of oemof.network, Edge was subclass to Node. Thus, the Flow had the attribute "_in_edges" though there was no Edge connected to an Edge. Now, the Edge (sand thus Flow) is cleaned up in oemof.network. As attributes starting with "_" are ignored anyway, this commit does not even change any behaviour.
|
It turned out that the number of required changes is very limited. In the end, I just had to change the order two expressions are evaluated that return booleans and are connected by an or. So, I will just merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.