Addition of some features implemented by ipudk #504

fwitte · 2024-04-16T15:10:51Z

PR in favor of #502

(cherry picked from commit c06cdeb)

(cherry picked from commit 56eb349)

(cherry picked from commit 81c4fe2)

(cherry picked from commit a22f267)

…way to access TminPsat internally (cherry picked from commit 1a64bd6)

(cherry picked from commit cc22938)

(cherry picked from commit 1a766a1)

(cherry picked from commit d97dcd7)

…Psat - removing use of PropsSI (cherry picked from commit 4d2458e)

(cherry picked from commit d615ba6)

(cherry picked from commit 1f0a2b3)

…rWithPressureLoss example (cherry picked from commit b5206a8)

(cherry picked from commit 6d8a34f)

(cherry picked from commit ecb718c)

(cherry picked from commit 9143f09)

(cherry picked from commit acb41ef)

(cherry picked from commit c8415d6)

(cherry picked from commit 537c7f5)

…odels are not very useful for tespy I believe (cherry picked from commit bed22e1)

(cherry picked from commit f762746)

(cherry picked from commit 33c76cc)

(cherry picked from commit 68eadb0)

…a separator. And I think we should also not use sum to 1 concentration, only when one fluid is remaining in some connector..

…spy. (the solver obs out on systems with very small mass flow...). Quick and dirty handleling by adding normalized increments to the residual norm

…nside sourcea nad sink

… remove prints

…ests The additions are very specific, therefore I will remove them for now. However, they showcase the flexibility of tespy. I would like to see them in an own repository or move some to a tutorial/example section of the docs in order to showcase the possibilities through customization.

pep8speaks · 2024-04-16T16:48:47Z

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/tespy/components/component.py:

Line 221:80: E501 line too long (99 > 79 characters)
Line 221:90: E251 unexpected spaces around keyword / parameter equals
Line 221:92: E251 unexpected spaces around keyword / parameter equals

In the file src/tespy/components/nodes/base.py:

Line 174:25: E261 at least two spaces before inline comment
Line 175:23: W291 trailing whitespace
Line 206:25: E261 at least two spaces before inline comment

In the file src/tespy/connections/connection.py:

Line 496:46: E231 missing whitespace after ':'
Line 620:80: E501 line too long (115 > 79 characters)
Line 623:80: E501 line too long (85 > 79 characters)
Line 665:80: E501 line too long (123 > 79 characters)
Line 669:80: E501 line too long (81 > 79 characters)
Line 670:80: E501 line too long (114 > 79 characters)
Line 674:80: E501 line too long (105 > 79 characters)
Line 679:80: E501 line too long (89 > 79 characters)
Line 680:80: E501 line too long (105 > 79 characters)
Line 753:80: E501 line too long (125 > 79 characters)
Line 761:80: E501 line too long (136 > 79 characters)
Line 765:80: E501 line too long (136 > 79 characters)
Line 769:80: E501 line too long (116 > 79 characters)
Line 805:80: E501 line too long (129 > 79 characters)
Line 849:80: E501 line too long (110 > 79 characters)
Line 855:80: E501 line too long (116 > 79 characters)
Line 859:80: E501 line too long (121 > 79 characters)
Line 901:80: E501 line too long (140 > 79 characters)
Line 920:34: E713 test for membership should be 'not in'
Line 920:80: E501 line too long (195 > 79 characters)
Line 921:80: E501 line too long (126 > 79 characters)
Line 991:71: E231 missing whitespace after ','
Line 991:80: E501 line too long (99 > 79 characters)
Line 1009:80: E501 line too long (105 > 79 characters)
Line 1042:17: E225 missing whitespace around operator
Line 1043:17: E225 missing whitespace around operator
Line 1055:80: E501 line too long (109 > 79 characters)
Line 1056:80: E501 line too long (109 > 79 characters)

In the file src/tespy/networks/network.py:

Line 755:14: E231 missing whitespace after ','
Line 757:21: E231 missing whitespace after ','
Line 757:50: E231 missing whitespace after ','
Line 758:17: E265 block comment should start with '# '
Line 758:80: E501 line too long (83 > 79 characters)
Line 775:80: E501 line too long (86 > 79 characters)
Line 785:14: E231 missing whitespace after ','
Line 787:21: E231 missing whitespace after ','
Line 787:50: E231 missing whitespace after ','
Line 788:17: E265 block comment should start with '# '
Line 788:80: E501 line too long (83 > 79 characters)
Line 810:46: E231 missing whitespace after ','
Line 1127:80: E501 line too long (81 > 79 characters)
Line 1129:80: E501 line too long (80 > 79 characters)
Line 1288:41: E231 missing whitespace after ','
Line 1291:80: E501 line too long (97 > 79 characters)
Line 1292:80: E501 line too long (126 > 79 characters)
Line 1741:26: E231 missing whitespace after ','
Line 1790:80: E501 line too long (85 > 79 characters)
Line 1794:80: E501 line too long (87 > 79 characters)
Line 1855:80: E501 line too long (124 > 79 characters)
Line 1862:80: E501 line too long (135 > 79 characters)
Line 1867:5: E303 too many blank lines (2)
Line 2111:80: E501 line too long (80 > 79 characters)
Line 2249:26: E221 multiple spaces before operator
Line 2249:80: E501 line too long (108 > 79 characters)
Line 2249:86: E261 at least two spaces before inline comment
Line 2250:26: E221 multiple spaces before operator
Line 2250:59: E261 at least two spaces before inline comment
Line 2251:26: E221 multiple spaces before operator
Line 2251:59: E261 at least two spaces before inline comment
Line 2251:80: E501 line too long (80 > 79 characters)
Line 2252:23: E221 multiple spaces before operator
Line 2252:80: E501 line too long (109 > 79 characters)
Line 2252:87: E261 at least two spaces before inline comment
Line 2259:22: E221 multiple spaces before operator
Line 2264:80: E501 line too long (103 > 79 characters)
Line 2346:80: E501 line too long (85 > 79 characters)
Line 2355:80: E501 line too long (85 > 79 characters)
Line 2379:80: E501 line too long (87 > 79 characters)
Line 2395:80: E501 line too long (86 > 79 characters)
Line 2475:14: E261 at least two spaces before inline comment
Line 2475:15: E262 inline comment should start with '# '
Line 2622:42: E231 missing whitespace after ','
Line 2623:80: E501 line too long (93 > 79 characters)
Line 2624:73: E261 at least two spaces before inline comment
Line 2624:80: E501 line too long (120 > 79 characters)
Line 2625:80: E501 line too long (127 > 79 characters)

In the file src/tespy/networks/network_reader.py:

Line 338:80: E501 line too long (85 > 79 characters)
Line 341:80: E501 line too long (84 > 79 characters)

In the file src/tespy/tools/data_containers.py:

Line 328:80: E501 line too long (82 > 79 characters)
Line 595:1: E302 expected 2 blank lines, found 1

In the file src/tespy/tools/fluid_properties/functions.py:

Line 96:80: E501 line too long (85 > 79 characters)
Line 99:21: E225 missing whitespace around operator
Line 99:30: E225 missing whitespace around operator
Line 104:62: E203 whitespace before ':'
Line 111:80: E501 line too long (99 > 79 characters)
Line 112:80: E501 line too long (102 > 79 characters)
Line 118:80: E501 line too long (99 > 79 characters)
Line 119:80: E501 line too long (102 > 79 characters)
Line 123:80: E501 line too long (91 > 79 characters)
Line 126:80: E501 line too long (95 > 79 characters)
Line 128:80: E501 line too long (98 > 79 characters)
Line 139:80: E501 line too long (86 > 79 characters)
Line 150:80: E501 line too long (80 > 79 characters)
Line 151:80: E501 line too long (80 > 79 characters)
Line 153:80: E501 line too long (93 > 79 characters)
Line 171:80: E501 line too long (80 > 79 characters)
Line 172:80: E501 line too long (80 > 79 characters)
Line 173:21: E225 missing whitespace around operator
Line 175:23: E225 missing whitespace around operator
Line 183:80: E501 line too long (93 > 79 characters)
Line 194:80: E501 line too long (93 > 79 characters)
Line 206:80: E501 line too long (93 > 79 characters)
Line 225:80: E501 line too long (80 > 79 characters)
Line 226:80: E501 line too long (80 > 79 characters)
Line 227:21: E225 missing whitespace around operator
Line 227:30: E225 missing whitespace around operator
Line 229:80: E501 line too long (84 > 79 characters)
Line 230:80: E501 line too long (84 > 79 characters)
Line 232:26: E203 whitespace before ','
Line 232:80: E501 line too long (81 > 79 characters)
Line 242:80: E501 line too long (86 > 79 characters)
Line 253:62: E203 whitespace before ':'
Line 266:80: E501 line too long (80 > 79 characters)
Line 267:80: E501 line too long (80 > 79 characters)
Line 268:21: E225 missing whitespace around operator
Line 268:30: E225 missing whitespace around operator
Line 270:80: E501 line too long (84 > 79 characters)
Line 271:80: E501 line too long (84 > 79 characters)
Line 273:26: E203 whitespace before ','
Line 273:80: E501 line too long (81 > 79 characters)
Line 297:80: E501 line too long (86 > 79 characters)
Line 315:80: E501 line too long (94 > 79 characters)

In the file src/tespy/tools/fluid_properties/helpers.py:

Line 67:80: E501 line too long (112 > 79 characters)

In the file src/tespy/tools/fluid_properties/mixtures.py:

Line 84:1: W293 blank line contains whitespace
Line 174:80: E501 line too long (81 > 79 characters)
Line 230:80: E501 line too long (93 > 79 characters)

In the file src/tespy/tools/fluid_properties/wrappers.py:

Line 204:17: E722 do not use bare 'except'
Line 209:80: E501 line too long (92 > 79 characters)
Line 214:21: E722 do not use bare 'except'
Line 216:42: E231 missing whitespace after ','
Line 216:80: E501 line too long (91 > 79 characters)
Line 221:21: E722 do not use bare 'except'

In the file src/tespy/tools/global_vars.py:

Line 23:23: E203 whitespace before ','
Line 23:80: E501 line too long (81 > 79 characters)
Line 24:80: E501 line too long (83 > 79 characters)
Line 25:80: E501 line too long (83 > 79 characters)
Line 26:80: E501 line too long (83 > 79 characters)
Line 27:80: E501 line too long (84 > 79 characters)
Line 28:28: E203 whitespace before ','
Line 28:80: E501 line too long (93 > 79 characters)
Line 29:80: E501 line too long (93 > 79 characters)
Line 30:80: E501 line too long (93 > 79 characters)
Line 31:80: E501 line too long (94 > 79 characters)
Line 32:80: E501 line too long (94 > 79 characters)
Line 34:9: E265 block comment should start with '# '
Line 35:9: E265 block comment should start with '# '
Line 41:80: E501 line too long (84 > 79 characters)
Line 43:9: E265 block comment should start with '# '
Line 44:9: E265 block comment should start with '# '
Line 50:24: E203 whitespace before ','
Line 51:27: E203 whitespace before ','
Line 52:27: E203 whitespace before ','
Line 53:27: E203 whitespace before ','
Line 54:28: E203 whitespace before ','
Line 56:29: E203 whitespace before ','
Line 57:30: E203 whitespace before ','
Line 58:30: E203 whitespace before ','
Line 59:31: E203 whitespace before ','
Line 60:31: E203 whitespace before ','
Line 62:9: E265 block comment should start with '# '
Line 63:9: E265 block comment should start with '# '
Line 70:80: E501 line too long (94 > 79 characters)
Line 72:9: E265 block comment should start with '# '
Line 73:9: E265 block comment should start with '# '
Line 85:80: E501 line too long (94 > 79 characters)
Line 86:80: E501 line too long (94 > 79 characters)

In the file src/tespy/tools/helpers.py:

Line 113:1: E302 expected 2 blank lines, found 1
Line 119:1: E302 expected 2 blank lines, found 1

Comment last updated at 2024-04-16 17:23:01 UTC

…erences from the bounds

kaern added 30 commits November 3, 2023 08:27

regiter coolrop

9424307

Cherry picked EEMAP/dev to avoid rewritten history

9c46ff5

register nested root for coolprop

a260449

(cherry picked from commit c06cdeb)

updating examples

6712c5e

(cherry picked from commit 56eb349)

successfully runing examples 1,4,8,9

99dbc57

(cherry picked from commit 81c4fe2)

testing heat exchangers

4a92f6e

(cherry picked from commit a22f267)

solving P > Psat for incompressible "water" :: I believe there is no …

f2cbc57

…way to access TminPsat internally (cherry picked from commit 1a64bd6)

updating SimpleHeatExchangerDeltaP with new jacobian structure

b6867c7

(cherry picked from commit cc22938)

heat exchanger with loss updated with new jacobian structure

022d5f3

(cherry picked from commit 1a766a1)

Finally happy with all combinations of LF, Q_loss an Q_total working

e24e4a7

(cherry picked from commit d97dcd7)

solving P > Psat more elegantly :: INCOMP pressure is now limited by …

5489598

…Psat - removing use of PropsSI (cherry picked from commit 4d2458e)

updating some errors in jacobian derrivatives

54196b8

(cherry picked from commit d615ba6)

updating heat exchanger and merge tests

8017ffa

(cherry picked from commit 1f0a2b3)

constraints are now inherited and deleted if necessary. Added Splitte…

6302fab

…rWithPressureLoss example (cherry picked from commit b5206a8)

Flow splitter working and added flow splitter with pressure drop

a2b4624

(cherry picked from commit 6d8a34f)

reorganizing splitters

5d647a6

(cherry picked from commit ecb718c)

working on SFS

de6c045

(cherry picked from commit 9143f09)

fixing tespy separator model (is_var on the jacobian outlets )

0c3fbeb

(cherry picked from commit acb41ef)

cleaning test files for not using Food properties

2ac4f23

(cherry picked from commit c8415d6)

And the BUS is running

5182217

(cherry picked from commit 537c7f5)

splitting energySupplyComponents from newComponents.. Energy Supply m…

5cd4b9a

…odels are not very useful for tespy I believe (cherry picked from commit bed22e1)

working energy models and examples

7448aa3

(cherry picked from commit f762746)

renaming example files

45b57fc

(cherry picked from commit 33c76cc)

deleting old energy supply models, updating names and examples

9e2df2f

(cherry picked from commit 68eadb0)

new folder names

31234c2

I think we should always include and fluid composition equations for …

086991e

…a separator. And I think we should also not use sum to 1 concentration, only when one fluid is remaining in some connector..

I think we should always include and fluid composition equations for …

ab0c8f5

…a separator. And I think we should also not use sum to 1 concentration, only when one fluid is remaining in some connector..

let's syncronize the way fluids are specified, also for the split_fluid

bbcb721

let's keep backward compatibility

1046dd5

need force_state, limit_increments and RobustRelax

14fb14f

kaern and others added 26 commits December 14, 2023 09:43

more units for components

6d6cb89

goofy unit

41fea62

units

2c29210

equal To of SFS model

448c0e5

add to export debugging class list

a36009d

Huge issue on scaling residuals and jacobians, which is missing in te…

89be247

…spy. (the solver obs out on systems with very small mass flow...). Quick and dirty handleling by adding normalized increments to the residual norm

safe delete object

e4c26e7

unit

beae8fe

adding new features for energy supply, e.g. mass flow specification i…

b7be6f6

…nside sourcea nad sink

Fix unit conversion (switched MWh and GWh)

e5a9e51

boiler, compressor, ref unit and heat pump with usefull ratios

57b9603

adding functionality for energy supply

9bb892c

flow energy node

d7f4225

Changing SI unit of KPI

ab5a9f6

fixing basic heatpump and refunit in energy supply

118e210

working on custom fluid wrapper

c70deca

working mix of custom fluid wrapper and coolprop

28a2a4a

change folder

b4aa8be

mixtures with custem wrapper and coolprop working

dd0857c

Merge EEMAP/dev into dev

5a006b5

Make some quick fixes to integrate state and force_state keywords and…

54ee55a

… remove prints

Fix errors related to (temporary) kwargs in h_pT functions

d0cb31b

Align some styling and run isort

eb8fd8b

Fix examples related to removal of automatic fluid balance constraint

05fc9bc

Allow for higher temperatures in mixtures of gases

51f5e3c

fwitte added 3 commits April 16, 2024 18:53

Remove unused imports

9720117

Fix more imports

360b9f2

Add a value sanity check for fluid mass fraction to prevent tiny diff…

f14d535

…erences from the bounds

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addition of some features implemented by ipudk #504

Addition of some features implemented by ipudk #504

fwitte commented Apr 16, 2024

pep8speaks commented Apr 16, 2024 •

edited

Loading

Addition of some features implemented by ipudk #504

Are you sure you want to change the base?

Addition of some features implemented by ipudk #504

Conversation

fwitte commented Apr 16, 2024

pep8speaks commented Apr 16, 2024 • edited Loading

Comment last updated at 2024-04-16 17:23:01 UTC

pep8speaks commented Apr 16, 2024 •

edited

Loading