Mark 'arbitrary' Presto aggregate function order sensitive (facebooki…

…ncubator#9646)

Summary:
As discussed in facebookincubator#9274 (comment), mark arbitrary aggregate as order sensitive, as a prerequisite for facebookincubator#9482

Pull Request resolved: facebookincubator#9646

Reviewed By: pedroerp

Differential Revision: D56710594

Pulled By: kagamiori

fbshipit-source-id: ce37c1d6bd707360531fd7bc8da03d638fbc55ac

velox/functions/prestosql/aggregates/ArbitraryAggregate.cpp

@@ -343,7 +343,6 @@ void registerArbitraryAggregate(
                 inputType->kindName());
         }
       },
-      {false /*orderSensitive*/},
       withCompanionFunctions,
       overwrite);
 }

velox/functions/prestosql/aggregates/tests/AggregationFunctionRegTest.cpp

@@ -64,7 +64,6 @@ TEST_F(AggregationFunctionRegTest, orderSensitive) {
       "min",
       "max",
       "count",
-      "arbitrary",
       "bool_and",
       "bool_or",
       "bitwise_and_agg",
@@ -74,8 +73,7 @@ TEST_F(AggregationFunctionRegTest, orderSensitive) {
       "count_if",
       "geometric_mean",
       "histogram",
-      "reduce_agg",
-      "any_value"};
+      "reduce_agg"};
   aggregate::prestosql::registerAllAggregateFunctions();
   exec::aggregateFunctions().withRLock([&](const auto& aggrFuncMap) {
     for (const auto& entry : aggrFuncMap) {
@@ -88,7 +86,7 @@ TEST_F(AggregationFunctionRegTest, orderSensitive) {
 
   // Test some but not all order sensitive functions
   std::set<std::string> orderSensitiveFunctions = {
-      "array_agg", "map_agg", "map_union", "set_agg"};
+      "array_agg", "arbitrary", "any_value", "map_agg", "map_union", "set_agg"};
   exec::aggregateFunctions().withRLock([&](const auto& aggrFuncMap) {
     for (const auto& entry : aggrFuncMap) {
       if (entry.second.metadata.orderSensitive) {