Skip to content

Commit

Permalink
Install duckdb dependency in setup-ubuntu.sh (facebookincubator#9648)
Browse files Browse the repository at this point in the history
Summary:
I note duckdb is installed by [setup-centos8.sh]( https://github.com/facebookincubator/velox/blob/main/scripts/setup-centos8.sh#L177), but not by setup-ubuntu.sh.

Pull Request resolved: facebookincubator#9648

Reviewed By: pedroerp

Differential Revision: D56710871

Pulled By: kagamiori

fbshipit-source-id: cccdfea7c9ef043dd9de06e0390811b2d68481a6
  • Loading branch information
PHILO-HE authored and facebook-github-bot committed Apr 29, 2024
1 parent 7295997 commit 9370245
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions scripts/setup-ubuntu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ FMT_VERSION=10.1.1
BOOST_VERSION=boost-1.84.0
NPROC=$(getconf _NPROCESSORS_ONLN)
DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)}
BUILD_DUCKDB="${BUILD_DUCKDB:-true}"
export CMAKE_BUILD_TYPE=Release
SUDO="${SUDO:-"sudo --preserve-env"}"

Expand All @@ -53,6 +54,7 @@ function install_build_prerequisites {
build-essential \
cmake \
ccache \
curl \
ninja-build \
checkinstall \
git \
Expand Down Expand Up @@ -141,6 +143,17 @@ function install_conda {
bash Miniconda3-latest-Linux-$ARCH.sh -b -p $MINICONDA_PATH
}

function install_duckdb {
if $BUILD_DUCKDB ; then
echo 'Building DuckDB'
wget_and_untar https://github.com/duckdb/duckdb/archive/refs/tags/v0.8.1.tar.gz duckdb
(
cd duckdb
cmake_install -DBUILD_UNITTESTS=OFF -DENABLE_SANITIZER=OFF -DENABLE_UBSAN=OFF -DBUILD_SHELL=OFF -DEXPORT_DLL_SYMBOLS=OFF -DCMAKE_BUILD_TYPE=Release
)
fi
}

function install_cuda {
# See https://developer.nvidia.com/cuda-downloads
if ! dpkg -l cuda-keyring 1>/dev/null; then
Expand All @@ -162,6 +175,7 @@ function install_velox_deps {
run_and_time install_mvfst
run_and_time install_fbthrift
run_and_time install_conda
run_and_time install_duckdb
}

function install_apt_deps {
Expand Down

0 comments on commit 9370245

Please sign in to comment.