forked from sxswdemo/github-book
-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid change directly after loading.
Setting the _selected field on a model causes a navModel update, which in turn causes head to change because of serialisation differences. To avoid this, we don't call setNavModel if only _selected has been changed. One other small change to avoid doNotReparse from leaking out.
- Loading branch information
Showing
1 changed file
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because options is passed by reference, setting doNotReparse on it travels back up the calling chain and could potentially cause unexpected results. It does not appear to make any difference at the moment though, I just think this is more correct.