Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Refactor setup.py with sub-modules #154

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

MementoRC
Copy link
Collaborator

@MementoRC MementoRC commented Mar 15, 2024

Proposal to re-organize the setup.py with a setup_tools package encompassing the tools needed to build coincurve.

Many times I got confused when working on the setup.py. The changes are mostly limited to the essential of this idea, I tried not to mix-in the other ideas(CMake and version) - It makes the rebasing a bit more difficult, but I think it may be simpler for you to review

Also, I think this is going to be directly re-usable for the hatchling conversion later on

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (bb94b90) to head (9451b35).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          11       11           
  Lines         566      566           
  Branches       67       67           
=======================================
  Hits          485      485           
  Misses         45       45           
  Partials       36       36           

@MementoRC MementoRC merged commit aa90760 into ofek:master Mar 16, 2024
11 checks passed
@MementoRC MementoRC deleted the feat/refactor-setup-modules branch March 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants