Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated check.py test script using pytest #80

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ofer1katz
Copy link
Contributor

Changed check.py test script to test/test_canonical_head.py using pytest.
Fixed public/flights/index.html, public/index.html according to the test results.
Updated .gitignore.
Added requirements.txt file

…est. fixed public/flights/index.html, public/index.html according to the test results. updated .gitignore. added requirements.txt file
@eilatc
Copy link
Collaborator

eilatc commented Mar 15, 2020

@oferb
please review

@eilatc eilatc requested a review from oferb March 15, 2020 18:05
Copy link
Owner

@oferb oferb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good PR!
Thanks for this.
Just left one comment, but otherwise approved.

public/flights/index.html Show resolved Hide resolved
public/flights/index.html Show resolved Hide resolved
@oferb
Copy link
Owner

oferb commented Mar 15, 2020

Approved. Can you resolve conflicts and then we merge it?

@ofer1katz
Copy link
Contributor Author

Approved. Can you resolve conflicts and then we merge it?

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants