Skip to content

Commit

Permalink
prov/psm3: fix logical atomic function calls
Browse files Browse the repository at this point in the history
psm3 advertises support for logical ops (lor, land, lxor)
with all datatypes but the functions are only defined for
integer types. When the atomic op is called with a non-integer
type, it drops down to the default case and returns an error
(FI_ENOTSUPP)

Signed-off-by: Alexia Ingerson <[email protected]>
  • Loading branch information
aingerson committed Oct 10, 2024
1 parent ac24eeb commit 1a4f1f7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions prov/psm3/src/psmx3_atomic.c
Original file line number Diff line number Diff line change
Expand Up @@ -401,12 +401,12 @@ static int psmx3_atomic_do_write(void *dest, void *src,
break;

case FI_LOR:
SWITCH_INT_TYPE(datatype,PSMX3_ATOMIC_WRITE,
SWITCH_ALL_TYPE(datatype,PSMX3_ATOMIC_WRITE,
dest,src,count,PSMX3_LOR);
break;

case FI_LAND:
SWITCH_INT_TYPE(datatype,PSMX3_ATOMIC_WRITE,
SWITCH_ALL_TYPE(datatype,PSMX3_ATOMIC_WRITE,
dest,src,count,PSMX3_LAND);
break;

Expand All @@ -421,7 +421,7 @@ static int psmx3_atomic_do_write(void *dest, void *src,
break;

case FI_LXOR:
SWITCH_INT_TYPE(datatype,PSMX3_ATOMIC_WRITE,
SWITCH_ALL_TYPE(datatype,PSMX3_ATOMIC_WRITE,
dest,src,count,PSMX3_LXOR);
break;

Expand Down

0 comments on commit 1a4f1f7

Please sign in to comment.