Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabtests/prov/lpp: fix compile warnings #10399

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fabtests/prov/lpp: fix compile warnings #10399

merged 1 commit into from
Sep 24, 2024

Conversation

aingerson
Copy link
Contributor

Fix compiler warnings about incorrect placement of const and inline identifiers

Fix compiler warnings about incorrect placement of const
and inline identifiers

Signed-off-by: Alexia Ingerson <[email protected]>
@aingerson
Copy link
Contributor Author

@tstruk Fixing some compiler warnings - please take a look.
There are also a bunch of LPP provider coverity warnings. Let @j-xiong if you don't have access to view those and he can add you

@aingerson
Copy link
Contributor Author

@tstruk Oh and there is one more compile warning about FI_MR_BASIC which I didn't fix but please address that one whenever you have a minute - thanks!

prov/lpp/src/test_util.c: In function ‘util_init’:                                               
prov/lpp/src/test_util.c:134:13: warning: 'FI_MR_BASIC' is deprecated                            
  hints.domain_attr->mr_mode = FI_MR_BASIC; 

@tstruk
Copy link
Contributor

tstruk commented Sep 19, 2024

@aingerson Thanks for fixing the warnings. All the changes look good to me.
I don't have access to coverity results. @j-xiong could you please grant me access?

@tstruk
Copy link
Contributor

tstruk commented Sep 19, 2024

@tstruk Oh and there is one more compile warning about FI_MR_BASIC which I didn't fix but please address that one whenever you have a minute - thanks!

prov/lpp/src/test_util.c: In function ‘util_init’:                                               
prov/lpp/src/test_util.c:134:13: warning: 'FI_MR_BASIC' is deprecated                            
  hints.domain_attr->mr_mode = FI_MR_BASIC; 

Will do

@j-xiong
Copy link
Contributor

j-xiong commented Sep 19, 2024

@tstruk I sent you the invitation for Coverity access.

@tstruk
Copy link
Contributor

tstruk commented Sep 19, 2024

@j-xiong Got it. Thanks.

@j-xiong j-xiong merged commit 0071415 into ofiwg:main Sep 24, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants