git/hooks: Prevent pre-push from looping format check (envoyproxy#29580)

Signed-off-by: Ryan Northey <[email protected]>

support/hooks/pre-push

@@ -70,16 +70,17 @@ do
     # `$CLANG_FORMAT` and `$BUILDIFY` are defined, or that the default values it
     # assumes for these variables correspond to real binaries on the system. If
     # either of these things aren't true, the check fails.
-    for i in $(git diff --name-only "$RANGE" --diff-filter=ACMR --ignore-submodules=all 2>&1); do
-      echo -ne "  Checking format for $i - "
-      bazel run //tools/code_format:check_format -- check "$i" || exit 1
 
-      # TODO(phlax): It seems this is not running in CI anymore and is now finding issues
-      # in merged PRs. Unify this hook and format checks in CI when the new format tool is rolled
-      # out.
-      # echo "  Checking spelling for $i"
-      # "$SCRIPT_DIR"/spelling/check_spelling_pedantic.py check "$i" || exit 1
-    done
+    _CHANGES=$(git diff --name-only "$RANGE" --diff-filter=ACMR --ignore-submodules=all 2>&1 | tr '\n' ' ')
+    IFS=' ' read -ra CHANGES <<< "$_CHANGES"
+
+    echo -ne "  Checking format for ${CHANGES[*]} - "
+    bazel run //tools/code_format:check_format -- check "${CHANGES[@]}" || exit 1
+    # TODO(phlax): It seems this is not running in CI anymore and is now finding issues
+    # in merged PRs. Unify this hook and format checks in CI when the new format tool is rolled
+    # out.
+    # echo "  Checking spelling for $i"
+    # "$SCRIPT_DIR"/spelling/check_spelling_pedantic.py check "${CHANGES[@]}" || exit 1
 
     # TODO(mattklein123): Optimally we would be able to do this on a per-file basis.
     "$SCRIPT_DIR"/proto_format/proto_format.sh check || exit 1

tools/code_format/check_format.py

@@ -151,7 +151,7 @@ def excluded_prefixes(self):
             self.config.paths["excluded"] + tuple(self.args.add_excluded_prefixes)
             if self.args.add_excluded_prefixes else self.config.paths["excluded"])
 
-    @property
+    @cached_property
     def error_messages(self):
         return []