Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICD11 patch: load all to in-memory; but search filter by is_leaf=True #1661

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Brief of changes made.

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fd7fd29) 59.46% compared to head (9e45047) 59.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1661   +/-   ##
=======================================
  Coverage   59.46%   59.46%           
=======================================
  Files         208      208           
  Lines       11283    11283           
  Branches     1597     1597           
=======================================
  Hits         6709     6709           
  Misses       4372     4372           
  Partials      202      202           
Files Coverage Δ
care/facility/api/viewsets/icd.py 40.00% <ø> (ø)
care/facility/static_data/icd11.py 70.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rithviknishad rithviknishad added the P1 High priority; urgent label Oct 6, 2023
@nihal467
Copy link
Member

nihal467 commented Oct 6, 2023

LGTM, tested through tunnel

@vigneshhari vigneshhari merged commit ab695cd into master Oct 6, 2023
7 checks passed
@vigneshhari vigneshhari deleted the icd11-patch-group-select branch October 6, 2023 15:25
@sentry-io
Copy link

sentry-io bot commented Oct 10, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ error: unterminated character set at position 46 /api/v1/icd/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: "no such value '1435254666' in index 'id'" Patient tab export is not working properly
5 participants