Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows diagnoses starting with disease code to be available in ICD11 Search #1823

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 16, 2024

Proposed Changes

  • Allows diagnoses starting with disease code to be available in ICD11 searched regardless of whether it's a chapter/category/leaf entity or not

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (91ed61a) 61.25% compared to head (59444cd) 61.34%.

Files Patch % Lines
care/abdm/utils/fhir.py 0.00% 1 Missing ⚠️
care/facility/models/patient.py 0.00% 1 Missing ⚠️
care/hcx/api/viewsets/gateway.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
+ Coverage   61.25%   61.34%   +0.08%     
==========================================
  Files         208      208              
  Lines       11530    11532       +2     
  Branches     1647     1647              
==========================================
+ Hits         7063     7074      +11     
+ Misses       4199     4184      -15     
- Partials      268      274       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari
Copy link
Member

Fix tests and we should be good to merge

@rithviknishad
Copy link
Member Author

@vigneshhari the issue was when running the tests, the in-memory table was being built before the DB was populated with the ICD11 data. Hence 0 records were loaded onto the in-memory table.

It was not being lazy loaded accidentally due to other functions in the same file being imported from other places. I've now ensured that ICD11 is always lazy-loaded.

@vigneshhari vigneshhari merged commit e64fc1f into master Jan 17, 2024
11 checks passed
@vigneshhari vigneshhari deleted the rithviknishad/icd11/has_code branch January 17, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants