-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make care single source of truth for asset config on middleware #2000
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2000 +/- ##
===========================================
+ Coverage 62.20% 62.43% +0.23%
===========================================
Files 221 222 +1
Lines 12204 12359 +155
Branches 1742 1764 +22
===========================================
+ Hits 7591 7716 +125
- Misses 4305 4320 +15
- Partials 308 323 +15 ☔ View full report in Codecov by Sentry. |
Asset.objects.filter( | ||
current_location__facility=current_location.facility | ||
) | ||
.annotate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converting this to or was breaking the validation
) | ||
.annotate( | ||
resolved_middleware_hostname=Coalesce( | ||
NullIf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if you can use the or statement here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converting this to or was returning assets from other hostnames as well
Proposed Changes
Associated Issue
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins