-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reply feature for Doctor notes #2160
Reply feature for Doctor notes #2160
Conversation
@UdaySagar-Git fix the lint and test in the PR |
@nihal467 fixed ! |
@UdaySagar-Git how will you ensure that the notes that you fetch that are replies include the parent in response?, also what if the notes have replies, but it were not fetched in the current response |
@sainak , thanks for pointing that out. It won't fetch the parent if there are more notes. Instead of sending just the ID, sending the complete parent object along with the note would solve this. Should I consider that and make changes in frontend according to it? |
@UdaySagar-Git we could add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than this, LGTM.
Tests would be appreciated 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests needed
@rithviknishad forgot to commit 😅 , |
@UdaySagar-Git can you make the changes requested |
@UdaySagar-Git what is the update on the PR |
@nihal467 this pr is ready for a final review |
@vigneshhari can you please review this , added a extra validation check for consultation |
@nihal467 can you try re-running the tests now ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2160 +/- ##
===========================================
+ Coverage 65.41% 65.42% +0.01%
===========================================
Files 242 242
Lines 13948 13965 +17
Branches 1931 1935 +4
===========================================
+ Hits 9124 9137 +13
- Misses 4443 4445 +2
- Partials 381 383 +2 ☔ View full report in Codecov by Sentry. |
@sainak re-review required |
@sainak why are we not merging this? |
@bodhish this needs a final review from vignesh |
Associated Issue
Frontend PR: ohcnetwork/care_fe#7805
Architecture changes
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins