Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to filter users with no home facility #2332

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

shivankacker
Copy link
Member

Proposed Changes

  • Allows you to filter users with no home facility assigned.

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.86%. Comparing base (c1a74f2) to head (58e3251).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2332      +/-   ##
===========================================
+ Coverage    63.82%   63.86%   +0.03%     
===========================================
  Files          239      239              
  Lines        13416    13439      +23     
  Branches      1909     1914       +5     
===========================================
+ Hits          8563     8583      +20     
- Misses        4505     4508       +3     
  Partials       348      348              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

nihal467 commented Aug 7, 2024

@skks1212 functionality looks good, for backend review, even though the frontend is having a small state management issue

@shivankacker
Copy link
Member Author

@nihal467 fixed frontend issue

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests needed

@nihal467
Copy link
Member

LGTM , @shivankacker can you look into rithvik's comment

@nihal467 nihal467 requested a review from sainak August 13, 2024 07:43
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just test what happens if the value is not a valid uuid

@shivankacker
Copy link
Member Author

@nihal467 @sainak Tests added

@nihal467 nihal467 requested a review from vigneshhari August 13, 2024 15:36
@vigneshhari vigneshhari merged commit a686bca into develop Aug 21, 2024
2 of 3 checks passed
@vigneshhari vigneshhari deleted the no-home-facility-filter branch August 21, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants