-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to filter users with no home facility #2332
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2332 +/- ##
===========================================
+ Coverage 63.82% 63.86% +0.03%
===========================================
Files 239 239
Lines 13416 13439 +23
Branches 1909 1914 +5
===========================================
+ Hits 8563 8583 +20
- Misses 4505 4508 +3
Partials 348 348 ☔ View full report in Codecov by Sentry. |
@skks1212 functionality looks good, for backend review, even though the frontend is having a small state management issue |
@nihal467 fixed frontend issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests needed
LGTM , @shivankacker can you look into rithvik's comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just test what happens if the value is not a valid uuid
Proposed Changes
Associated Issue
Merge Checklist
/docs
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins