Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated populate fixing-investigation command #2500

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

DraKen0009
Copy link
Contributor

@DraKen0009 DraKen0009 commented Sep 26, 2024

Proposed Changes

  • Fixed duplication of data in investigation group table
  • Fixed many to many relations when populating investigation data
  • Updated Investigation data and investigation group data

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Linting Complete

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@DraKen0009 DraKen0009 requested a review from a team as a code owner September 26, 2024 02:08
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 69.91%. Comparing base (8bac44a) to head (77581f7).

Files with missing lines Patch % Lines
...ers/management/commands/populate_investigations.py 0.00% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2500      +/-   ##
===========================================
- Coverage    70.00%   69.91%   -0.09%     
===========================================
  Files          198      198              
  Lines        11662    11677      +15     
  Branches      1605     1608       +3     
===========================================
  Hits          8164     8164              
- Misses        3107     3122      +15     
  Partials       391      391              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bodhish
Copy link
Member

bodhish commented Oct 18, 2024

@DraKen0009 do follow up and close this

@DraKen0009
Copy link
Contributor Author

@sainak updated, can you please run the workflows once

@sainak
Copy link
Member

sainak commented Oct 23, 2024

@DraKen0009 can you add a test case that validates the groups are being linked correctly

you can run the command using django.core.management.call_command

@DraKen0009
Copy link
Contributor Author

So basically after running the command , I need to loop over the data in json and compare them with the data present in the model (db)?

@sainak
Copy link
Member

sainak commented Oct 23, 2024

So basically after running the command , I need to loop over the data in json and compare them with the data present in the model (db)?

just check a few records

@DraKen0009
Copy link
Contributor Author

@sainak can you please cehck the test cases and let me know if they require any changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs in populate investigations command Expanding Investigations Seed list
3 participants