Added validation to prevent duplicate IP numbers in same facility #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2530 +/- ##
===========================================
+ Coverage 65.59% 65.60% +0.01%
===========================================
Files 223 223
Lines 13383 13387 +4
Branches 1855 1857 +2
===========================================
+ Hits 8779 8783 +4
Misses 4218 4218
Partials 386 386 ☔ View full report in Codecov by Sentry. |
sainak
reviewed
Oct 11, 2024
Comment on lines
+622
to
+624
| result_count = PatientConsultation.objects.filter( | ||
| facility=facility, patient_no=patient_no | ||
| ).count() |
There was a problem hiding this comment.
we've had issue with readmissions using this validation
ohcnetwork/care_fe#7798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins