-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing everything related to camera in favour of camera plugin #2610
Open
DraKen0009
wants to merge
22
commits into
ohcnetwork:develop
Choose a base branch
from
DraKen0009:adding-camera-plugin
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
51a7a40
added a camera plugin application
DraKen0009 3b6f32e
added a camera plugin application
DraKen0009 3939d06
merged conflicts
DraKen0009 d30ec6a
merged conflicts
DraKen0009 6128345
merged conflicts resolved
DraKen0009 c4a8904
removed camera related code
DraKen0009 d3c5b14
removed camera related code
DraKen0009 b29def8
asset model updates for making asset data dynamic
DraKen0009 75d4204
update plug configs
DraKen0009 90e8259
resolved merge conflicts
DraKen0009 e7c774e
resolve code rabbit comments
DraKen0009 122b92f
Merge branch 'develop' into adding-camera-plugin
DraKen0009 38d5196
Merge branch 'develop' into adding-camera-plugin
rithviknishad 6d4bf27
revert removing reference to old camera preset model
rithviknishad 11b6367
Merge branch 'refs/heads/master' into adding-camera-plugin
DraKen0009 19c2b74
fixed classname field in serializer to be dynamic
DraKen0009 8d4581f
fixed member function addition
DraKen0009 5a6a8fa
Merge branch 'ohcnetwork:develop' into adding-camera-plugin
DraKen0009 85eb618
Merge branch 'master' into adding-camera-plugin
DraKen0009 88003ae
Merge branch 'adding-camera-plugin' of draken:DraKen0009/care into ad…
DraKen0009 2e72d44
Merge branch 'master' into adding-camera-plugin
DraKen0009 421400a
fixed migrations
DraKen0009 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
25 changes: 25 additions & 0 deletions
25
care/facility/migrations/0468_alter_asset_asset_class_alter_asset_meta.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Generated by Django 5.1.2 on 2024-11-20 20:53 | ||
|
||
import care.facility.models.json_schema.asset | ||
import care.utils.models.validators | ||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('facility', '0468_alter_facilitypatientstatshistory_unique_together_and_more'), | ||
] | ||
|
||
operations = [ | ||
migrations.AlterField( | ||
model_name='asset', | ||
name='asset_class', | ||
field=models.CharField(blank=True, default=None, max_length=20, null=True), | ||
), | ||
migrations.AlterField( | ||
model_name='asset', | ||
name='meta', | ||
field=models.JSONField(blank=True, default=dict, validators=[care.utils.models.validators.DynamicJSONFieldSchemaValidator(care.facility.models.json_schema.asset.get_dynamic_asset_meta)]), | ||
), | ||
] |
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Oh, I see what happened with those migration numbers...
It seems the migration is actually referencing a non-existent file. The dependency points to '0468_alter_facilitypatientstatshistory_unique_together_and_more', but that file doesn't exist in the codebase. The correct migration appears to be '0469_alter_facilitypatientstatshistory_unique_together_and_more'.
🔗 Analysis chain
Interesting choice of migration numbering there...
The migration depends on '0468_alter_facilitypatientstatshistory_unique_together_and_more' while being numbered 0468 itself. This could potentially cause confusion in the migration history.
Let's check the migration history:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 144
Script:
Length of output: 522
🧰 Tools
🪛 Ruff (0.8.2)
11-11: Single quotes found but double quotes preferred
Replace single quotes with double quotes
(Q000)
11-11: Single quotes found but double quotes preferred
Replace single quotes with double quotes
(Q000)