Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing everything related to camera in favour of camera plugin #2610
base: develop
Are you sure you want to change the base?
Removing everything related to camera in favour of camera plugin #2610
Changes from 10 commits
51a7a40
3b6f32e
3939d06
d30ec6a
6128345
c4a8904
d3c5b14
b29def8
75d4204
90e8259
e7c774e
122b92f
38d5196
6d4bf27
11b6367
19c2b74
8d4581f
5a6a8fa
85eb618
88003ae
2e72d44
421400a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Variable naming inconsistency with 'movable_assets'
It appears that
movable_assets
actually contains asset classes wheremember.is_movable
isFalse
, meaning they are non-movable assets. Perhaps renaming the variable tonon_movable_assets
would improve clarity.This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing this now will cause a pending make migration as 0 references are there to the old
CameraPreset
model now. lets remove it in the second part PR where we would be deleting the old model.