-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment Section in the shifting detail page is stretching the page #6637
Comments
@rithviknishad Please assign me this issue .To resolve the bug, I will inspect and adjust the CSS styles associated with the comment section on shifting detail pages, ensuring responsive design and dynamic sizing. Will Thoroughly test the changes with different comment quantities and devices to ensure optimal page layout |
A simple solution would be to passing perPage 5 or 6. by default per Page is 14, causing the entire page to stretch significantly |
@rithviknishad @nihal467 Here are two simple possible solutions
|
Hey @rithviknishad @nihal467 I tried to see this error on the webpage but when I try to post a comment it shows an error "Not found" , is this issue still relevant? |
Hey @nihal467. We can enhance the user experience by adding a view more button. Based on that, when the user clicks on it, an extra 5 more comments will be visible, and we'll repeat the same until the comment exists. And intially Top 5 comments will be only displayed. |
Hey, if the issue is not completed, I can work on this. |
Shifting.details._.CARE.mp4i have submitted my PR #7364, kindly review it , if any changes need to be done , intimate me @rithviknishad |
@rithviknishad , is there any corrections needed to be done ? if so, intimate me...? |
@rithviknishad , whats the status on this PR?? is any changes required... |
Hey, not sure if you've missed it, but I've requested changes in your PR two days ago |
@rithviknishad You instructed me to reuse the existing type, but it lacks the required types for comments. Additionally, you mentioned reusing the ReadMore.tsx component, but when I attempt to do so, it doesn't align with the Comment Box. Modifying the CSS of the ReadMore component might disrupt the UI of other components, so I opted to write new code to address this issue. |
@rithviknishad , i've submitted new PR ,correcting all the changes u asked for , and also added Multilingual support for all the Button i have used , check my PR #7402 |
hey @rithviknishad , whats the status on my PR.... |
@Thanush19 Unassigning you from this issue due to inactivity. Feel free to reassign yourself if you are still working on it. |
@rithviknishad hello,is this issue still open? if yes, I would like to work on this issue. |
Holding this on the back burner now, as shifting details page might get redesigned (as grid/table format). If so, could redesign this page along with that 🤔 |
Describe the bug
When we post multiple comment on a shifting detail page, it keep on stretching the page to the bottom
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It shouldn't be stretching the page a lot and the entire page should be effectively utilizing the white space
Screenshots
The text was updated successfully, but these errors were encountered: