-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #6637: Comment Section in the shifting detail page is stretching the page. #9318
Conversation
WalkthroughThe changes involve modifying the Changes
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (1)src/CAREUI/misc/PaginatedList.tsx (1)
While reducing Consider these alternatives:
Let's check other usages of PaginatedList to assess the impact: Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@ayushsaini7717 Please do not take up issues that are already assigned. If there's been no activity, make sure to clarify that first and get the issue assigned to you before opening a PR. Plus, this doesn't address the issue, we don't want to restrict to 5 per page (and even with just 5, there's a ton of white space on the right side). |
Proposed Changes
What Does This PR Do?
This PR fixes issue Comment Section in the shifting detail page is stretching the page #6637 by changing the DEFAULT_PER_PAGE_LIMIT from 14 to 5. by this change only 5 comments are shown per page.
@ohcnetwork/care-fe-code-reviewers
Testing:
Verified locally by adding multiple comments in shifting detail page.
Tested in Chrome.
Impact:
No breaking changes expected.
Screenshots:
Summary by CodeRabbit
New Features
Bug Fixes