Cleanup capacity related fields from facility

[bodhish]

Proposed Changes

Lets remove facility capacity and beds.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features

  • Streamlined facility creation process by removing unnecessary steps and fields.
  • Enhanced user interface for facility management by retaining essential components.

• Bug Fixes

  • Improved error handling and validation in facility creation forms.

• Bug Fixes

  • Removed components related to bed and staff capacity management, simplifying the user experience.

• Chores

  • Cleaned up codebase by removing obsolete components and associated logic.
  • Removed several API routes related to hospital bed management and triage functionalities.
  • Updated type declarations to reflect changes in data structures.

[coderabbitai]

Walkthrough

This pull request involves the removal of several components related to facility management, specifically targeting bed capacity, staff capacity, and associated functionalities. The changes simplify the facility management interface by eliminating components like BedCapacity, BedTypeCard, FacilityBedCapacity, FacilityStaffList, StaffCapacity, and StaffCountCard. The FacilityCreate component has been modified to remove oxygen and cylinder capacity-related properties, streamlining the facility creation process. The FacilityHome component has also been updated to remove sections displaying oxygen and staff information. Additionally, multiple API routes and TypeScript interfaces related to these functionalities have been deleted.

Changes

File	Change Summary
src/components/Facility/BedCapacity.tsx	Completely removed React component for managing bed capacity
src/components/Facility/BedTypeCard.tsx	Deleted component for displaying bed type information
src/components/Facility/FacilityBedCapacity.tsx	Removed component for displaying and managing facility bed capacity
src/components/Facility/FacilityCreate.tsx	Removed oxygen and cylinder capacity properties from form and validation
src/components/Facility/FacilityHome.tsx	Eliminated bed capacity, staff list, and oxygen information sections
src/components/Facility/FacilityStaffList.tsx	Deleted component for displaying facility staff members
src/components/Facility/StaffCapacity.tsx	Removed component for managing staff capacity
src/components/Facility/StaffCountCard.tsx	Deleted component for managing doctor counts
src/Routers/routes/FacilityRoutes.tsx	Removed routes for triage forms
src/Utils/request/api.tsx	Deleted multiple API routes related to hospital bed and triage management
src/components/ExternalResult/models.ts	Removed TypeScript interfaces related to local bodies and bed capacity
src/components/Facility/FacilityHomeTriage.tsx	Deleted component for displaying triage data
src/components/Facility/TriageForm.tsx	Removed component for managing triage form
src/components/Facility/models.tsx	Updated FacilityModel interface and removed related interfaces
src/components/Patient/PatientRegister.tsx	Updated localBody state type from ILocalBodies[] to LocalBodyModel[]

Possibly related PRs

• Fix: Bed capacity pop up errors #9123: Modifications to the BedCapacity component.
• Facility bed capacity verification test #9145: Introduction of structured data objects for managing facility data.
• Sidebar Duotone icons #9281: Updates to the CareIcon component to support duo-tone icons.

Suggested labels

needs review, tested

Suggested reviewers

• nihal467
• rithviknishad
• shivankacker

Poem

🏥 Facility components, once so grand,
Swept away by a rabbit's command!
Bed counts and staff lists, now out of sight,
Simplicity wins this coding fight! 🐰
A cleaner path, our code now gleams bright!

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a680e69 and c464e63.

📒 Files selected for processing (2)

• src/Utils/request/api.tsx (1 hunks)
• src/components/Patient/PatientRegister.tsx (2 hunks)

🔇 Additional comments (2)

src/Utils/request/api.tsx (1)

728-728: LGTM! Type updates for local body responses

The changes to use LocalBodyModel[] instead of ILocalBodies[] for the response types of local body-related routes are consistent with the broader refactoring of local body data structures across the codebase.

Also applies to: 733-733

src/components/Patient/PatientRegister.tsx (1)

23-23: LGTM! Type updates for local body state

The changes to use LocalBodyModel instead of ILocalBodies for the local body state are consistent with the type updates in the API routes and maintain type safety across the application.

Also applies to: 208-208

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	c464e63
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/675ea7a53ea53a00085bc076
😎 Deploy Preview	https://deploy-preview-9436--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[cloudflare-workers-and-pages]

Deploying care-fe with    Cloudflare Pages

Latest commit:	c464e63
Status:	✅  Deploy successful!
Preview URL:	https://47ca19fb.care-fe.pages.dev
Branch Preview URL:	https://cleanup-facility.care-fe.pages.dev

View logs

[cypress]

CARE    Run #4026

Run Properties:   Failed #4026  •  c464e63ca3: Cleanup capacity related fields from facility

Project	CARE
Branch Review	cleanup-facility
Run status	Failed #4026
Run duration	06m 32s
Commit	c464e63ca3: Cleanup capacity related fields from facility
Committer	Bodhish Thomas
View all properties for this run ↗︎

---

Test results
Failures	8
Flaky	0
Pending	0
Skipped	0
Passing	138
View all changes introduced in this branch ↗︎

---

Tests for review

  FacilityCreation.cy.ts • 6 failed tests • UI-Chrome

View Output

Test		Artifacts
Facility Creation > Verify Facility Triage Function		Test Replay Screenshots
Facility Creation > Create a new facility with multiple bed and doctor capacity		Test Replay Screenshots
Facility Creation > Create a new facility with single bed and doctor capacity		Test Replay Screenshots
Facility Creation > Create a new facility with no bed and doctor capacity		Test Replay Screenshots
Facility Creation > Update the existing facility		Test Replay Screenshots
Facility Creation > Configure the existing facility		Test Replay Screenshots

  FacilityManage.cy.ts • 2 failed tests • UI-Chrome

View Output

Test		Artifacts
Facility Manage Functions > Modify doctor capacity in Facility detail page		Test Replay Screenshots
Facility Manage Functions > Modify bed capacity in Facility detail page		Test Replay Screenshots

[bodhish]

@nihal467 can you cleap up the spec ☝️