Fix: Unwanted scrolling and spacing on availability page

[rajku-dev]

Proposed Changes

• Fixes Unwanted scrolling and spacing on Availability Page #10128
  
  
  
  

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• UI/Layout Improvements
  • Adjusted scroll area heights in the Users Availability Tab for better responsiveness.
  • Reduced vertical padding in Schedule Exceptions and Schedule Templates pages when no items are found, enhancing layout compactness for empty state messages.

[coderabbitai]

Walkthrough

The pull request focuses on adjusting UI spacing and scrolling behavior across multiple components in the Scheduling and Users sections. Specifically, the changes reduce vertical padding in components displaying "no data" messages and modify scroll area heights in the UserAvailabilityTab. These modifications aim to address unwanted scrolling and excessive blank space when no schedule exceptions or templates are present.

Changes

File	Change Summary
src/components/Users/UserAvailabilityTab.tsx	Modified ScrollArea height properties to be more flexible, using max-h-[calc(100vh-18rem)] overflow-auto and max-h-[22rem] overflow-auto
src/pages/Scheduling/ScheduleExceptions.tsx	Reduced vertical padding from py-64 to py-16 for "no exceptions" message
src/pages/Scheduling/ScheduleTemplates.tsx	Reduced vertical padding from py-64 to py-16 for "no templates" message

Assessment against linked issues

Objective	Addressed	Explanation
Reduce unwanted scrolling	✅
Minimize blank space when no exceptions exist	✅

Possibly related PRs

• User Availabilities Exception related fixes #9977: Changes in UserAvailabilityTab.tsx related to user availabilities
• Fix : Date field overflow in exception form in mobile view #10112: Modifications to scheduling exceptions layout
• Fixed alignment of components in mobile view #10038: UI responsiveness fixes

Suggested labels

needs review, tested

Suggested reviewers

• rithviknishad
• Jacobjeevan

Poem

🐰 Scroll no more, space be tight
Padding trimmed, layout just right
No blanks, no scroll, UI so neat
A rabbit's design, a coding feat!
Efficiency dances, pixels align 🎨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aaa0e16 and 97da08c.

📒 Files selected for processing (1)

• src/components/Users/UserAvailabilityTab.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/components/Users/UserAvailabilityTab.tsx

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: cypress-run (1)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	97da08c
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/679315d4139c480008915419
😎 Deploy Preview	https://deploy-preview-10130--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/pages/Scheduling/ScheduleExceptions.tsx (1)

39-39: Use a standardized “no data” spacing approach across the app.
This reduced padding will help address unwanted scrolling and keep layouts more compact. However, ensure that you consistently apply similar spacing to all “no data” placeholders across the codebase to maintain uniformity.

src/components/Users/UserAvailabilityTab.tsx (1)

285-285: Maintain consistency with other ScrollAreas.
Using max-h-[22rem] with overflow-auto provides a more adaptable layout. Consider coordinating this approach with line 213 so that transitions and scroll behavior remain uniform across the app.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19141a3 and aaa0e16.

📒 Files selected for processing (3)

• src/components/Users/UserAvailabilityTab.tsx (2 hunks)
• src/pages/Scheduling/ScheduleExceptions.tsx (1 hunks)
• src/pages/Scheduling/ScheduleTemplates.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/pages/Scheduling/ScheduleTemplates.tsx

🔇 Additional comments (1)

src/components/Users/UserAvailabilityTab.tsx (1)

213-213: Confirm no overflow on smaller screens.
Switching from a fixed h-[calc(100vh-24rem)] to max-h-[calc(100vh-18rem)] min-h-3 overflow-auto is a good approach for flexibility. However, ensure it behaves well on smaller viewports and does not create partial or hidden content.

[github-actions]

@rajku-dev Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌