Remove index-based numbering from appointments table row #10338

rithviknishad · 2025-01-31T12:03:46Z

Proposed Changes

Fixes Disallow Users From Creating Multiple Tokens for Same Session in a single day #10307

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Style
- Removed index display in appointments table rendering
- Simplified mapping of appointments array

Fixes #10307

coderabbitai · 2025-01-31T12:03:56Z

Walkthrough

The pull request modifies the Appointments component in the patient details tab by removing the index parameter from the appointments.map() method. This change eliminates the display of sequential numbering for appointments in the table, effectively removing the index column that was previously showing appointment numbers.

Changes

File	Change Summary
`src/components/Patient/PatientDetailsTab/Appointments.tsx`	Removed index parameter from `appointments.map()` and deleted the line displaying appointment index

Assessment against linked issues

Objective	Addressed	Explanation
Remove unwanted number in appointments [#10307]	✅
Create single token per session per day	❓	No changes related to token creation logic
Add user's missing pic	❌	No changes to user picture
Add "Updated by" information	❌	No changes to update tracking

Possibly related PRs

Appointments: redirect to patient page post update status to in_consultation #9672: Modifications to AppointmentDetailsPage component
Fix spacing in user list, remove scrollbar on large screens, and adjust schedule appointment button #9864: Changes in Appointments component layout and styling
Remove status change dropdown from AppointmentActions component #10248: Removal of status change dropdown in AppointmentActions

Suggested labels

needs review

Suggested reviewers

Jacobjeevan

Poem

🐰 Hop, hop, through the code we go,
Indexes vanish, no numbers to show!
Appointments clean, no digits in sight,
A rabbit's touch makes the table just right! 🎉

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8d5348 and f6f10e7.

📒 Files selected for processing (1)

src/components/Patient/PatientDetailsTab/Appointments.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: cypress-run (1)
GitHub Check: Cloudflare Pages: care-fe

🔇 Additional comments (1)

src/components/Patient/PatientDetailsTab/Appointments.tsx (1)

96-96: LGTM! Consider verifying accessibility impact.

The removal of index-based numbering aligns with the PR objective and simplifies the code. However, please verify that this change doesn't impact any screen readers or accessibility features that might have relied on the sequential numbering for navigation or context.

Run the following script to check for any accessibility-related code or aria-labels that might have referenced the index:

✅ Verification successful

✅ No accessibility impact from removing index parameter

The table implementation follows accessibility best practices using semantic table elements and stable appointment IDs for row identification. The removal of the index parameter does not affect screen readers or navigation as no accessibility features were dependent on it.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Search for accessibility-related code that might reference indices
rg -i "aria-label|role|aria-|tabindex" src/components/Patient/PatientDetailsTab/
Length of output: 2068

Script:
#!/bin/bash
# Get the full context of the appointments table implementation
echo "=== Appointments.tsx content ==="
cat src/components/Patient/PatientDetailsTab/Appointments.tsx

echo -e "\n=== Table-related accessibility patterns ==="
# Search for table-related elements and attributes
rg -i "table|thead|tbody|tr|th|td" src/components/Patient/PatientDetailsTab/Appointments.tsx
Length of output: 7388

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-31T12:04:03Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`f6f10e7`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/679cbc2506833500087be882
😎 Deploy Preview	https://deploy-preview-10338--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2025-01-31T12:05:20Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`f6f10e7`
Status:	✅ Deploy successful!
Preview URL:	https://adb2e09d.care-fe.pages.dev
Branch Preview URL:	https://rithbiknishad-fix-10307.care-fe.pages.dev

View logs

cypress · 2025-01-31T12:11:26Z

CARE Run #4548

Run Properties: Passed #4548 • f6f10e7970: Remove index-based numbering from appointments table row

Project	`CARE`
Branch Review	`rithbiknishad/fix/10307`
Run status	`Passed #4548`
Run duration	`06m 01s`
Commit	`f6f10e7970: Remove index-based numbering from appointments table row`
Committer	`Rithvik Nishad`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`10`
View all changes introduced in this branch ↗︎

nihal467 · 2025-01-31T12:16:48Z

LGTM

github-actions · 2025-01-31T12:38:41Z

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Remove index-based numbering from appointments table row

f6f10e7

Fixes #10307

rithviknishad requested a review from a team as a code owner January 31, 2025 12:03

nihal467 added needs review tested labels Jan 31, 2025

Jacobjeevan approved these changes Jan 31, 2025

View reviewed changes

bodhish approved these changes Jan 31, 2025

View reviewed changes

bodhish merged commit 7b61652 into develop Jan 31, 2025
30 checks passed

bodhish deleted the rithbiknishad/fix/10307 branch January 31, 2025 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove index-based numbering from appointments table row #10338

Remove index-based numbering from appointments table row #10338

rithviknishad commented Jan 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 31, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 31, 2025

cypress bot commented Jan 31, 2025

nihal467 commented Jan 31, 2025

github-actions bot commented Jan 31, 2025

Remove index-based numbering from appointments table row #10338

Remove index-based numbering from appointments table row #10338

Conversation

rithviknishad commented Jan 31, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 31, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 31, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Jan 31, 2025

Deploying care-fe with Cloudflare Pages

cypress bot commented Jan 31, 2025

CARE Run #4548

nihal467 commented Jan 31, 2025

github-actions bot commented Jan 31, 2025

rithviknishad commented Jan 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 31, 2025 •

edited

Loading