resolved Appointments select practitioner options Bug: popover inconsistent spacing between options within the popover content #10636
Conversation
…t spacing between the options bug
WalkthroughThe pull request refactors the user selection interface in the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant AP as AppointmentsPage
participant P as Popover
U->>AP: Open Appointments Page
AP->>P: Render user selection list (with structured layout)
U->>P: Click to open Popover
P->>U: Display list of users with names & types
U->>P: Select a user (or click "show all")
P->>AP: Update practitioner and slot query parameters
AP-->>U: Reflect selection in the interface
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| </CommandItem> | ||
| </PopoverClose> | ||
| ))} | ||
| <div className="flex flex-col align-top"> |
There was a problem hiding this comment.
what you've done is just a hack around instead of solving the root cause. the right way to solve this is to compose in this way without needing any extra div's or classes
<CommandItem key={...}>
<PopoverClose className="flex items-center gap-2">
...
</PopoverClose>
</CommandItem>There was a problem hiding this comment.
@rithviknishad ohh you're right that will be better will change it
|
@rithviknishad |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
85-85: Clarify the local dependency path.
The new dependency"care_fe": "file:"has been added. Please verify that the local dependency reference is complete and correct. In many cases, a local dependency path should include a relative path (e.g.,"file:./path/to/care_fe"), unless"file:"is intentionally used as a placeholder. Adding a brief inline comment for clarity could help future maintainers understand the intended structure.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.json(1 hunks)src/pages/Appointments/AppointmentsPage.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/pages/Appointments/AppointmentsPage.tsx
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Redirect rules - care-ohc
- GitHub Check: Header rules - care-ohc
- GitHub Check: Pages changed - care-ohc
- GitHub Check: Test
- GitHub Check: cypress-run (1)
rithviknishad
added
tested
and removed
invalid
|
@hrit2773 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
…t spacing between the options bug
Proposed Changes
Changed
From
To
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit