Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added patient category descriptions for ICU bed patients #7970

Merged
merged 10 commits into from
Aug 25, 2024
Merged

Added patient category descriptions for ICU bed patients #7970

merged 10 commits into from
Aug 25, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jun 3, 2024 •
edited
Loading

Dependent on ohcnetwork/care#2298

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner June 3, 2024 21:12
@vercel Vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 7:34am

@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ccb9553
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c83b296cbdbb00089efded
😎 Deploy Preview https://deploy-preview-7970--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Jun 3, 2024 •
edited
Loading

CARE    Run #3175

Run Properties:  status check passed Passed #3175  •  git commit ccb9553102: Added patient category descriptions for ICU bed patients
Project CARE
Branch Review patient-status-description
Run status status check passed Passed #3175
Run duration 02m 58s
Commit git commit ccb9553102: Added patient category descriptions for ICU bed patients
Committer Shivank Kacker
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 126
View all changes introduced in this branch ↗︎

@nihal467
Copy link
Member

nihal467 commented Jun 5, 2024

@skks1212 can you modify the PR based on the issue

@nihal467
Copy link
Member

nihal467 commented Jun 5, 2024 •
edited
Loading

@skks1212

image

  • In the log update patient category, the definition is always present , but as per issue, its should only be shown when patient is in icu bed

image

  • in the create consultation page, when i select icu bed, the patient category definition is not present

@shivankacker shivankacker changed the title Added patient code status descriptions for ICU bed patients Added patient category descriptions for ICU bed patients Jun 10, 2024
@nihal467
Copy link
Member

@skks1212 keeping this PR on hold, as there is a discussion going on in the related issue

@nihal467 nihal467 added the hold label Jun 10, 2024
@shivankacker shivankacker removed the hold label Jul 3, 2024
@nihal467
Copy link
Member

nihal467 commented Jul 8, 2024 •
edited
Loading

@skks1212
image

the issue is modified few days back, make the necessary changes to cypress and PR, and follow up on the ongoing discussion in the issue

@nihal467
Copy link
Member

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 8, 2024
@shivankacker shivankacker removed the merge conflict pull requests with merge conflict label Aug 23, 2024
rithviknishad
rithviknishad requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except missing i18n

@gigincg gigincg merged commit 348edf4 into develop Aug 25, 2024
60 of 62 checks passed
@gigincg gigincg deleted the patient-status-description branch August 25, 2024 14:44
@github-actions GitHub Actions
Copy link

@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad requested changes

@khavinshankar khavinshankar Awaiting requested review from khavinshankar

Assignees
No one assigned
Labels
needs review tested waiting for backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patient categorisation- add definitions
4 participants
@shivankacker @nihal467 @rithviknishad @gigincg