Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Notes TextArea; Improve i18n #8396

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

gigincg
Copy link
Member

@gigincg gigincg commented Aug 22, 2024

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@gigincg gigincg requested a review from a team as a code owner August 22, 2024 10:35
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 4:54pm

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 90a1a71
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c76cedffe28e000985cf11
😎 Deploy Preview https://deploy-preview-8396--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Aug 22, 2024



Test summary

126 0 0 0


Run details

Project CARE
Status Passed
Commit 08d048f
Started Aug 22, 2024 10:42 AM
Ended Aug 22, 2024 10:45 AM
Duration 03:00 💡
OS Linux Ubuntu -
Browser Chrome 128

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@nihal467
Copy link
Member

@gigincg
image

  • post sending the note, the text area height remain the same, as the dynamic height used by the previous message. the height of text box only reset, when you try to type a new message into it

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit a34d9e3 into develop Aug 22, 2024
26 of 28 checks passed
@khavinshankar khavinshankar deleted the discussion_notes_8367 branch August 22, 2024 17:08
Copy link

@gigincg Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Aug 23, 2024
* Improve Notes TextArea; Improve i18n

* Update defaultRows for Discussion Notes Page

* Reset on Clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion note: size of text input field
4 participants