Added: Warning for unsupported browsers #8417
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@AdityaJ2305 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
❌ Deploy Preview for care-net failed.
|
AdityaJ2305
changed the title
|
@AdityaJ2305 The warning seems a little excessive. Can you make it a little more subtle? |
|
@gigincg Sure |
@gigincg Let me know if it looks good or If there's anything to change. After confirmation I will make pull request for the same
|
|
@AdityaJ2305 Still Excessive IMO. A Transparent Gray Background with matching Text Colour should do it. Also, looking at your File changes, this seems to stay up across the platform. It needs to show up only in the Login Screen. |
|
@gigincg Should the warning message also be displayed on the Forgot Password page, in addition to the Login Screen? Or is it intended only for the Login Screen? |
|
Preferably only the login screen |
@gigincg Let me know if it looks good or If there's anything to change.
|
|
Should I make pull request for the same with updated changes ? |
@AdityaJ2305 you can continue pushing these changes to the existing branch, it'd automatically reflect in this PR. |
Co-authored-by: Rithvik Nishad <[email protected]>
|
Should I make the final commit ? @rithviknishad |
…ted package.json with new script
…d_Browsers updated browser-warning user agent parsing to precompiled regex
sainak
added
needs testing
and removed
changes required
Deploy-Failed
|
in the screenshot above i'm testing with version 80 of google chrome, which will be one of the unsupported browsers, but couldn't see the banner you mention in the screenshot, can you mention which version of chrome i should be using to see this error banner |
nihal467
added
question
|
On changing my useragent string to Chrome version 80, I can see the warning as shown here This is the UserAgent string that is showing the error for me |
|
@nihal467 I even tried using BrowserStack to test the deploy preview on
They seem to be showing the error banner as expected |
Ohh I just noticed in this, you're in the wrong deploy preview, it should be (https://deploy-preview-8417--care-ohc.netlify.app/) but you're testing it on (https://deploy-preview-8437--care-ohc.netlify.app/) |
rithviknishad
added
needs testing
and removed
question
|
👋 Hi, @AdityaJ2305, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
@itsRaCl thanks for the headsup, @khavinshankar the PR LGTM |
|
@sainak @AdityaJ2305 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist