Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hid the clear all filter button, When there are no filters #8449 #8451

Conversation

Adiflickzzz
Copy link

@Adiflickzzz Adiflickzzz commented Aug 31, 2024

Proposed Changes

@ohcnetwork/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Adiflickzzz Adiflickzzz requested a review from a team as a code owner August 31, 2024 11:35
Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 12fccdb
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66d6c938feebb20008a891d2
😎 Deploy Preview https://deploy-preview-8451--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Aug 31, 2024

@Adiflickzzz is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@Adiflickzzz
Copy link
Author

I have created a pull request to address this issue: #8449

Please review the changes when you get a chance. Thank you!

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right. children is there to allow any other complex badges. So for instance we apply consent filters, the badges no longer appear. Could you rething the solution?

image

@rithviknishad
Copy link
Member

Closing as duplicate; #8466 has fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show clear all filters button if there is no filter applied in Discharge patients page
3 participants