Minor Improvements to PatientRegistration; Drop External Results #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for care-net failed.
|
nihal467
added
needs review
cypress failed
|
|
|
@nihal467 Planning to remove the External Results Tab altogether. Any other references of External Results? |
nope, only this one reference remaining |
|
Based on the below conditions reviewing the PR :
|
nihal467
reviewed
Sep 3, 2024
| { | ||
| "personal_demographic": "Personal/Demographic Details", | ||
| "import_external_result": "Import From External Results", | ||
| "date_of_birth_note": "Date of Birth Note", |
There was a problem hiding this comment.
Suggested change
| "date_of_birth_note": "Date of Birth Note", | |
| "date_of_birth_note": "Please enter the correct date of birth for the patient", |
nihal467
reviewed
Sep 3, 2024
| "personal_demographic": "Personal/Demographic Details", | ||
| "import_external_result": "Import From External Results", | ||
| "date_of_birth_note": "Date of Birth Note", | ||
| "date_of_birth_note_description": "Please enter the correct date of birth for the patient", |
There was a problem hiding this comment.
Suggested change
| "date_of_birth_note_description": "Please enter the correct date of birth for the patient", | |
| "date_of_birth_note_description": "Each patient in the system is uniquely identifiable by the number and date of birth. Adding incorrect date of birth can result in duplication of patient records.", |
nihal467
reviewed
Sep 3, 2024
|
👋 Hi, @gigincg, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
@gigincg any progress? |
|
@bodhish Closing it for now, doesn't seem salvageable. Will redo with Health Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor Improvements made to PatientRegistration UI
Remove Support for External Results
TODO: Remove All other usage of External Results
@ohcnetwork/care-fe-code-reviewers
Merge Checklist