Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed vite config not reading env file #8465

Closed
wants to merge 1 commit into from
Closed

Fixed vite config not reading env file #8465

wants to merge 1 commit into from

Conversation

shivankacker
Copy link
Member

Proposed Changes

  • Currently when we need to run care with local backend, we need to specify the CARE_API env variable before npm run dev even if specified in .env.local
  • This will make sure that envs are picked up from .env.local before running the dev server.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner September 2, 2024 16:46
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 13011b3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66d5ec023b67960008a5ed13
😎 Deploy Preview https://deploy-preview-8465--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivankacker shivankacker self-assigned this Sep 2, 2024
@rithviknishad
Copy link
Member

@shivankacker already fixed in https://github.com/ohcnetwork/care_fe/pull/8445/files#diff-d33e979799a45c7c51752e9c8d96a3e452015d1a40b1e4b6ec6a98e92c4d8430

@shivankacker
Copy link
Member Author

Oof I see, closing

@rithviknishad rithviknishad deleted the fix-vite-config-env branch December 2, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shivankacker shivankacker

Labels
needs review needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivankacker @rithviknishad