Edited the nursing care section to a table under nursing tab of patient #8579
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const groupedByDate: any = {}; | ||
| dataToDisplay.forEach((item: any) => { | ||
| if (!groupedByDate[item.date]) { | ||
| groupedByDate[item.date] = []; | ||
| } | ||
| groupedByDate[item.date].push(item); | ||
| }); |
There was a problem hiding this comment.
Can we keep the logic too similar to what's present in the Routine table at least?
Ideally let's have a reusable component for this, as it could be re-used in couple of other places as well eventually.
Let's also avoid the usage of any
There was a problem hiding this comment.
Hey @rithviknishad, I tired to make a reusable component but the model of nursing care procedures is different and I am not able to extract data in the same way as in Routine , could you please guide me how can I proceed.
There was a problem hiding this comment.
You can pass the list of fields as a prop
There was a problem hiding this comment.
hey @rithviknishad , the Routine section has fields and subfields but the NURSING_CARE_PROCEDURES have only field , so using the same component is not looking good. I cat still use some conditions but that is not looking Ideal. Should I proceed with the component or leave it separately?
There was a problem hiding this comment.
you can simply skip defining sub-fields for procedures right?
There was a problem hiding this comment.
Hey @rithviknishad I made a new PR with the changes . #8608 .
There was a problem hiding this comment.
Also discard changes made to the lockfile.
|
Also, not all tasks mentioned in the issue is solved. Drop a comment once ready for review. |
|
Closing as duplicate of #8608 |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist