Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the multi-select component to immediately open onFocus #8598

Merged
merged 18 commits into from
Sep 24, 2024
Merged

Enhance the multi-select component to immediately open onFocus #8598

merged 18 commits into from
Sep 24, 2024

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Sep 23, 2024 •
edited
Loading

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@nihal467 nihal467 requested a review from a team as a code owner September 23, 2024 13:27
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit f80aac5
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66f255b18400c5000837995b
😎 Deploy Preview https://deploy-preview-8598--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Sep 23, 2024 •
edited
Loading

CARE    Run #3451

Run Properties:  status check passed Passed #3451  •  git commit f80aac510c: Enhance the multi-select component to immediately open onFocus
Project CARE
Branch Review enhance-multi-select
Run status status check passed Passed #3451
Run duration 03m 24s
Commit git commit f80aac510c: Enhance the multi-select component to immediately open onFocus
Committer Mohammed Nihal
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 121
View all changes introduced in this branch ↗︎

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 23, 2024 •
edited
Loading

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: f80aac5
Status: ✅  Deploy successful!
Preview URL: https://2dd0e328.care-fe.pages.dev
Branch Preview URL: https://enhance-multi-select.care-fe.pages.dev

View logs

@nihal467 nihal467 self-assigned this Sep 23, 2024
@rithviknishad rithviknishad merged commit 214b373 into develop Sep 24, 2024
25 checks passed
@rithviknishad rithviknishad deleted the enhance-multi-select branch September 24, 2024 06:09
@github-actions GitHub Actions
Copy link

@nihal467 @nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees

@nihal467 nihal467

Labels
None yet
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the flaky test in the entire cypress files due to recent backend changes
3 participants
@nihal467 @rithviknishad @khavinshankar