Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code splitting #8979

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve code splitting #8979

wants to merge 1 commit into from
+176 −196

Conversation

sainak
Copy link
Member

@sainak sainak commented Nov 1, 2024 •
edited
Loading

Proposed Changes

  • update the manual chunks function to bundle required dependencies with the lazy imported components
  • locales are no lazily loaded based on usage
  • huge components like PdfViewer, Login, ExcelFIleReader, Charts, KanbanBoards are now lazy loaded
  • fixed livekit component not splitting properly make DoctorLiveConnect lazy load care_livekit_fe#2
image image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner November 1, 2024 13:57
@netlify Netlify
Copy link

netlify bot commented Nov 1, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 5f0c213
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6724de49b6315e0009a33c9d
😎 Deploy Preview https://deploy-preview-8979--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Nov 1, 2024

CARE    Run #3786

Run Properties:  status check passed Passed #3786  •  git commit 5f0c213676: Improve code splitting
Project CARE
Branch Review sainak/code-splitting
Run status status check passed Passed #3786
Run duration 03m 29s
Commit git commit 5f0c213676: Improve code splitting
Committer Aakash Singh
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@shivankacker shivankacker Awaiting requested review from shivankacker

@khavinshankar khavinshankar Awaiting requested review from khavinshankar

@bodhish bodhish Awaiting requested review from bodhish

@Jacobjeevan Jacobjeevan Awaiting requested review from Jacobjeevan

Assignees
No one assigned
Labels
needs review needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sainak @rithviknishad