Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Util function for cleaner usage of TanStack useQuery #9395
Util function for cleaner usage of TanStack useQuery #9395
Changes from 4 commits
d0d31d6
db9a303
b41e19e
7ae322b
2653208
0c6f096
015a007
e6603ff
5a7510c
7283372
f4aff63
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider adding request body support
The createQuery function doesn't currently support request bodies for POST/PUT operations. Consider adding this capability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
URL encoding required for session expiry redirect parameter
The codebase shows consistent usage of URL encoding in other parts where query parameters contain URLs or text (e.g., in DoctorVideoSlideover.tsx). The current implementation in errorHandler.ts directly uses
window.location.href
without encoding, which could cause issues with special characters in the URL.src/Utils/request/errorHandler.ts
: Add URL encoding usingencodeURIComponent(window.location.href)
src/Utils/request/handleResponse.ts
: Same change needed for consistency🔗 Analysis chain
Verify URL encoding in session expiry redirect
The current implementation directly uses
window.location.href
in the redirect URL, which might need URL encoding.Let me check if there are any existing implementations of URL encoding in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 417
Script:
Length of output: 764