Adding mfa-screen

[AnveshNalimela]

Proposed Changes

• Fixes Add the MFA screens in login flow #9456
• Change 1
• Change 2
• More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features

  • Added a new authentication route to the application
  • Introduced a new authentication page with two-factor verification options
  • Implemented login form with recovery code support
  • Added internationalization for authentication screens

• Documentation

  • Included footer links to external resources and GitHub contribution page

[coderabbitai]

Walkthrough

The pull request introduces a new authentication route and component for Multi-Factor Authentication (MFA) in the application. A new route /authenticate is added to the SessionRouter.tsx, which renders the Authenticate component. The Authenticate.tsx component provides a comprehensive MFA screen with options for standard verification and recovery code entry, integrated with internationalization and UI components from the CAREUI library.

Changes

File	Change Summary
src/Routers/SessionRouter.tsx	Added new route /authenticate mapping to Authenticate component
src/components/Auth/Authenicate.tsx	New React component for MFA authentication screen with verification and recovery code forms

Assessment against linked issues

Objective	Addressed	Explanation
Add MFA screens in login flow [#9456]	✅
Implement TOTP with backup codes	✅
Use current sign-in page design for left half	❓	Design details not fully visible in the code

Suggested Labels

needs-review, tested

Suggested Reviewers

• rithviknishad
• khavinshankar

Poem

🐰 A Rabbit's Authentication Tale 🔐

Two-factor magic, codes so bright,
Hopping through security's might,
Verification dance, a digital delight,
Recovery paths gleaming with light,
Safe passage granted, future's insight! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

❌ Deploy Preview for care-ohc failed.

Name	Link
🔨 Latest commit	814837a
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/6774d9d831b77d0008942f94

[coderabbitai]

Actionable comments posted: 4

🧹 Nitpick comments (1)

src/components/Auth/Authenicate.tsx (1)

14-250: Naming and readability
The boolean state recoveryModal toggles between two modes in the same component rather than opening a modal. Consider renaming it to something like useRecoveryCode or refactoring to separate the forms to reduce confusion and increase readability.

-const [recoveryModal, setRecoveryModal] = useState(false);
+const [useRecoveryCode, setUseRecoveryCode] = useState(false);
 
 ...
   if (way === "Use a recovery code") {
-    setRecoveryModal(true);
+    setUseRecoveryCode(true);
   }

🧰 Tools

🪛 Biome (1.9.4)

[error] 69-69: Avoid passing content using the dangerouslySetInnerHTML prop.

Setting content using code can expose users to cross-site scripting (XSS) attacks

(lint/security/noDangerouslySetInnerHtml)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c92ab28 and 814837a.

📒 Files selected for processing (2)

• src/Routers/SessionRouter.tsx (2 hunks)
• src/components/Auth/Authenicate.tsx (1 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

src/components/Auth/Authenicate.tsx

[error] 69-69: Avoid passing content using the dangerouslySetInnerHTML prop.

Setting content using code can expose users to cross-site scripting (XSS) attacks

(lint/security/noDangerouslySetInnerHtml)

🔇 Additional comments (1)

src/Routers/SessionRouter.tsx (1)

72-72: New route addition
The addition of "/authenticate": () => <Authenticate /> is straightforward. Ensure that any library or custom hooks requiring authentication state updates are properly integrated if the user’s session or tokens need to be updated prior to or after rendering this page.

[bodhish]

This should also include the user pages right 🤔

[AnveshNalimela]

This should also include the user pages right 🤔

@bodhish Im not sure regarding that . But still is draft PR as backend was not ready for MFA

[github-actions]

👋 Hi, @AnveshNalimela,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

---

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

[nihal467]

@AnveshNalimela what is the status on this PR

[rithviknishad]

we can reopen this once backend is ready

[yash-learner]

@AnveshNalimela

Here is the ohcnetwork/care#2830 backend PR, you can start wiring the API's. There will not be any major changes.

Also, have a look at the design on user profile page where we keep these settings - https://www.figma.com/design/Z93EYKSa1MdBmXndsMBJSQ/Care?node-id=4785-4837&p=f&t=PuUQGBYFlMTytATd-0 and start working on this as well.