-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean Refactor Scribe as MFE | Support for Questionnaires #9636
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
cc09a00
Scribe for Questionnaire
shivankacker 5455150
added cui support for shadcn components
shivankacker 2a55a9e
fix merge conflicts
shivankacker 71fb36b
structured inputs
shivankacker cc2e16f
fix merge conflicts
shivankacker 470571b
Merge branch 'form-field-v1' of https://github.com/ohcnetwork/care_fe…
shivankacker 0be90e6
fix merge conflicts
shivankacker 35876be
support for other fields
shivankacker efa2f47
finishing up
shivankacker 719ab94
rebase to develop
shivankacker b964266
cleanup
shivankacker cff9c80
Init
shivankacker be083d4
Shifted structured prompts to scribe
shivankacker 626b8b9
updates
shivankacker fd7c909
changed state on injection
shivankacker a279cd2
Update Prompts; Add env
gigincg 77e7e1b
Merge branch 'develop' into form-field-scribe
gigincg b85c900
Merge branch 'develop' into form-field-scribe
gigincg bd5d914
Minor CHanges
gigincg 53e37a9
Fix Issues with AllergyQuestion
gigincg 62754a9
fix merge conlicts
shivankacker 3908e18
Merge branch 'develop' into form-field-scribe
gigincg ab34a7f
Merge branch 'develop' into form-field-scribe
gigincg f057eaa
Removed value injectors from structured inputs
shivankacker f926948
cleanup
shivankacker 7cc5e59
Working Demo
gigincg fef419a
fix merge conflicts
shivankacker e98095b
fix merge conflicts
shivankacker af626a2
removed all value injectors everywhere
shivankacker 13fa3b7
fix merge conflicts
shivankacker e1c36c8
more cleanup
shivankacker a7a6d4c
more cleanup
shivankacker a0ac2ac
updated encounter question to update on formstate
shivankacker fffa67e
Merge branch 'develop' into scribe-exit
shivankacker e45f502
cleanup and temp fix to get deploy preview running
shivankacker 9bbc954
Merge branch 'scribe-exit' of https://github.com/ohcnetwork/care_fe i…
shivankacker c972f4a
Merge branch 'develop' of https://github.com/ohcnetwork/care_fe into …
shivankacker 455a043
temp fixes to plugin setup
shivankacker 38b5a2a
more temp changes
shivankacker 5b41ef1
fixed allergy not getting updated when formstate changes
shivankacker 57167c7
remove console log
shivankacker c62f91e
Merge branch 'develop' into scribe-exit
gigincg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -212,4 +212,4 @@ | |
"node": ">=22.8.0" | ||
}, | ||
"packageManager": "[email protected]" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add input validation and error handling for the new URL format.
The new package extraction logic supports URLs with pipe-separated format but lacks validation and error handling. This could lead to runtime issues with malformed input.
Consider applying these improvements:
Also, consider removing or conditionally enabling the debug log based on NODE_ENV.
📝 Committable suggestion