Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Contact link does not work properly in the footer #38

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AdityaJ2305
Copy link

@AdityaJ2305 AdityaJ2305 commented Dec 10, 2024

Proposed Changes

Reviewer

@shivankacker

Screen-Recording

Screen.Recording.2024-12-10.at.11.10.27.PM.mp4

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for landing-ohc ready!

Name Link
🔨 Latest commit 4dc391f
🔍 Latest deploy log https://app.netlify.com/sites/landing-ohc/deploys/675e7ef74d6d500008cbdae2
😎 Deploy Preview https://deploy-preview-38--landing-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdityaJ2305 this should bring you to the home page, not the footer.

@AdityaJ2305
Copy link
Author

@AdityaJ2305 this should bring you to the home page, not the footer.

Ok, so we should remove the contact from header when we are already on home page ? I thought on footer we got GitHub yt slack links to get assistance and as per issue mentioned the bug was with scrolling

@shivankacker
Copy link
Member

@AdityaJ2305 the links stay the same. It will take you to the contact section of the home page. It is fine if it does not scroll for the time being

@AdityaJ2305
Copy link
Author

@AdityaJ2305 the links stay the same. It will take you to the contact section of the home page. It is fine if it does not scroll for the time being

@shivankacker, done with the changes.

@AdityaJ2305
Copy link
Author

Hey @shivankacker, can we implement scrolling for the home page and direct redirects for the other pages?

@AdityaJ2305
Copy link
Author

Hey @shivankacker , Could you review the changes ? and let me know changes required

@shivankacker
Copy link
Member

@AdityaJ2305 It is not taking me to the contact section when I am at another page.

Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes

@AdityaJ2305
Copy link
Author

AdityaJ2305 commented Dec 13, 2024

Please make the requested changes

It’s working fine locally 🤔. However, I’ve made changes based on the comment below.

Hey @shivankacker, can we implement scrolling for the home page and direct redirects for the other pages?

Screen.Recording.2024-12-13.at.8.43.16.PM.mov

@AdityaJ2305
Copy link
Author

Is the Netlify preview deployment getting updated or not? 😅

@AdityaJ2305
Copy link
Author

Hey @shivankacker, it’s working fine on deployment now. However, we can adjust the setTimeout duration based on the desired user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact link does not work properly in the footer
2 participants