-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Contact link does not work properly in the footer #38
base: main
Are you sure you want to change the base?
Fix: Contact link does not work properly in the footer #38
Conversation
✅ Deploy Preview for landing-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdityaJ2305 this should bring you to the home page, not the footer.
Ok, so we should remove the contact from header when we are already on home page ? I thought on footer we got GitHub yt slack links to get assistance and as per issue mentioned the bug was with scrolling |
@AdityaJ2305 the links stay the same. It will take you to the contact section of the home page. It is fine if it does not scroll for the time being |
@shivankacker, done with the changes. |
Hey @shivankacker, can we implement scrolling for the home page and direct redirects for the other pages? |
Hey @shivankacker , Could you review the changes ? and let me know changes required |
@AdityaJ2305 It is not taking me to the contact section when I am at another page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the requested changes
It’s working fine locally 🤔. However, I’ve made changes based on the comment below.
Screen.Recording.2024-12-13.at.8.43.16.PM.mov |
Is the Netlify preview deployment getting updated or not? 😅 |
Hey @shivankacker, it’s working fine on deployment now. However, we can adjust the setTimeout duration based on the desired user experience. |
Proposed Changes
Reviewer
@shivankacker
Screen-Recording
Screen.Recording.2024-12-10.at.11.10.27.PM.mp4