feat(leaderboard): add filtering, sorting, and search functionality in query params #527
+49
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leaderboard-develop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
requested changes
Oct 20, 2024
|
hey @rithviknishad did the changes can you again plse |
rithviknishad
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
LGTM, ordering doesn't seem to be working. But looks like its another bug already present in main branch and is unrelated to this PR. Filing a separate issue for it. (edit: #529)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Support for filtering based leaderboard results based on URL params #526